Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 208584 - Review Request: mirrormagic - Puzzle game where you steer a beam of light using mirrors
Summary: Review Request: mirrormagic - Puzzle game where you steer a beam of light usi...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michał Bentkowski
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-09-29 14:43 UTC by Hans de Goede
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-10-06 20:38:46 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Hans de Goede 2006-09-29 14:43:35 UTC 
Spec URL: http://people.atrpms.net/~hdegoede/mirrormagic.spec
SRPM URL: http://people.atrpms.net/~hdegoede/mirrormagic-2.0.2-1.fc6.src.rpm
Description:
MirrorMagic is a game where you shoot around obstacles to collect energy using
your beam. It is similar to "Mindbender" (Amiga) from the same author. The goal
is to work out how to get around obstacles to shoot energy containers with your
beam, thereby opening the path to the next level. Included are many levels
familiar from the games "Deflektor" and "Mindbender".
Comment 1 Michał Bentkowski 2006-09-29 18:32:52 UTC 
MUST items:
 * rpmlint doesn't show anything
 * package is named well
 * spec file name is good
 * package meets Packaging Guidelines
 * package is licensed with an GPL open-source compatible license
 * License field in spec file matches actual license
 * license file is included in %doc
 * md5sums are matching (32fd3909c1e27f493d89bc2276da6744)
 * package successfully compiles on x86_64
 * BuildRequires listed well
 * no locales
 * proper %post and %postun sections
 * not relocatable
 * package owns directories well
 * no duplicates in %files
 * every %files section includes %defattr
 * proper %clean section
 * macros used well
 * .desktop file looks good

THINGS to do:
 * this is not the blocker, but probably SDL-devel BR is unnecessary (I
haven't tested it)
 * the much more important problem is related with running the game on x86_64.
When I'm trying to do it, I get following message:

$ mirrormagic
mirrormagic: gadget incomplete (missing Bitmap)
mirrormagic: aborting

$ mirrormagic -v
mirrormagic: warning: cannot open configuration file '/home/ecik/.mirrormagic/
setup.conf'
mirrormagic: warning: using default setup values
mirrormagic: warning: cannot open configuration file '/home/ecik/.mirrormagic/
levelsetup.conf'
mirrormagic: warning: using default setup values
mirrormagic: warning: cannot open configuration file '/home/ecik/.mirrormagic/
levelsetup/classic_deflektor/levelsetup.conf'
mirrormagic: warning: using default setup values
mirrormagic: gadget incomplete (missing Bitmap)
mirrormagic: aborting
Comment 2 Hans de Goede 2006-09-30 12:54:27 UTC 
(In reply to comment #1)
> THINGS to do:
>  * this is not the blocker, but probably SDL-devel BR is unnecessary (I
> haven't tested it)

You're right, I've removed it.

>  * the much more important problem is related with running the game on x86_64.
> When I'm trying to do it, I get following message:
> 
> $ mirrormagic
> mirrormagic: gadget incomplete (missing Bitmap)
> mirrormagic: aborting
> 

Ah yes, I created this package on my 32 bit machine, and look and behold its not
64 bit clean. I've managed to fix this.

Here is a new version:
http://people.atrpms.net/~hdegoede/mirrormagic.spec
http://people.atrpms.net/~hdegoede/mirrormagic-2.0.2-2.fc6.src.rpm
Comment 3 Hans de Goede 2006-10-06 14:39:00 UTC 
Erm, I posted a new version with everything fixed, ping?
Comment 4 Michał Bentkowski 2006-10-06 17:50:19 UTC 
(In reply to comment #3)
> Erm, I posted a new version with everything fixed, ping?
> 

I'm sorry you had to wait.
I didn't response earlier as I had a serious problem with my mainboard.
Now my computer runs good and your package is good too.

APPROVED.
Comment 5 Hans de Goede 2006-10-06 20:38:46 UTC 
Thanks! Imported and build, closing.
Note You need to log in before you can comment on or make changes to this bug.