Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 210787 (pear-XML-Serializer) - Review Request: php-pear-XML-Serializer - Swiss-army knife for reading and writing XML files
Summary: Review Request: php-pear-XML-Serializer - Swiss-army knife for reading and wr...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: pear-XML-Serializer
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: pear-XML-Util
Blocks: FE-ACCEPT pear-Date-Holidays
TreeView+ depends on / blocked
 
Reported: 2006-10-15 00:47 UTC by Christopher Stone
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-10-26 21:57:28 UTC
Type: ---
Embargoed:
jwboyer: fedora-cvs+

Attachments (Terms of Use)

Description Christopher Stone 2006-10-15 00:47:37 UTC 
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-XML-Serializer.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-XML-Serializer-0.18.0-1.src.rpm

Description:
XML_Serializer serializes complex data structures like arrays or object as
XML documents. This class helps you generating any XML document you require
without the need for DOM.
Comment 1 Jason Tibbitts 2006-10-16 21:38:05 UTC 
I have php-pear-XML-Util in a local repo in order to build this.

I wonder if what's installed into /usr/share/pear/data/XML_Serializer/doc
shouldn't be %doc instead.

* source files match upstream:
   f9d7dd792a7b3258dfa4544017734cf8  XML_Serializer-0.18.0.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   php-pear(XML_Serializer) = 0.18.0
   php-pear-XML-Serializer = 0.18.0-1.fc6
  =
   /bin/sh
   /usr/bin/pear
   php-pear(PEAR)
   php-pear(XML_Parser)
   php-pear(XML_Util)
   php-xml

* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear module installation).
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
Comment 2 Christopher Stone 2006-10-17 03:42:05 UTC 
SPEC: http://tkmame.retrogames.com/fedora-extras/php-pear-XML-Serializer.spec
SRPM:
http://tkmame.retrogames.com/fedora-extras/php-pear-XML-Serializer-0.18.0-2.src.rpm

%changelog
* Mon Oct 16 2006 Christopher Stone <chris.stone> 0.18.0-2
- Move the todo file in %%{pear_datadir} into %%doc
Comment 3 Jason Tibbitts 2006-10-26 03:34:52 UTC 
OK, everything looks good.  And again, I apologize for taking so long with this.

APPROVED
Comment 4 Christopher Stone 2006-10-26 21:57:28 UTC 
No problem, thanks for the review.
Comment 5 Christopher Stone 2007-04-21 17:50:59 UTC 
Branch Package CVS Request
=======================
Package Name: php-pear-XML-Serializer
Short Description: Swiss-army knife for reading and writing XML files
Owners: chris.stone
Branches: EL-5
InitialCC:
Note You need to log in before you can comment on or make changes to this bug.