Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 210826 - Review Request: genius - An arbitrary precision integer and multiple precision floatingpoint calculator
Summary: Review Request: genius - An arbitrary precision integer and multiple precisio...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ed Hill
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-10-15 21:02 UTC by Gérard Milmeister
Modified: 2007-11-30 22:11 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-10-19 15:27:26 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Gérard Milmeister 2006-10-15 21:02:02 UTC 
Spec URL: http://math.ifi.unizh.ch/fedora/spec/genius.spec
SRPM URL: http://math.ifi.unizh.ch/fedora/5/i386/SRPMS.gemi/genius-0.7.6.1-1.src.rpm
Description:
Genius is a calculator program similar in some aspects to BC, Matlab
or Maple. GEL is the name of its extension language, in fact, a large
part of the standard genius functions are written in GEL itself.
Comment 1 Ed Hill 2006-10-15 22:24:39 UTC 
Hi Gerard, I just tried:

  mock -r fedora-5-i386-core genius-0.7.6.1-1.src.rpm

and it failed with the message:

  checking for XML::Parser... configure: error: XML::Parser perl 
    module is required for intltool

so it looks like a missing BR.
Comment 2 Gérard Milmeister 2006-10-16 14:27:01 UTC 
I forgot to run it through mock.
This one should work:
http://math.ifi.unizh.ch/fedora/5/i386/SRPMS.gemi/genius-0.7.6.1-2.src.rpm
Comment 3 Ed Hill 2006-10-18 04:14:03 UTC 
OK, the -2 release now builds with mock!

needswork:
 - rpmlint reports:
     E: genius-debuginfo script-without-shebang 
       /usr/src/debug/genius-0.7.6.1/mpfr/mul.c
     W: genius-devel no-documentation
     W: gnome-genius no-documentation
   the warnings are harmless and can be ignored but the error can be 
   fixed by changing the file's permissions within the build dir.

good:
 + spec is legible
 + source matches upstream
 + license looks good and is correctly included
 + spec file looks sane and is legible
 + builds in mock on FC-5 i386
 + uses %find_lang macro correctly
 + dir ownership look OK
 + appears to have no shared libs
 + permissions look good (except for the one exception above)
 + has proper clean section and command
 + proper use of devel
 + code not content
 + no *.la files
 + scripts appear to be sane
 + proper use of desktop-file-install
 + consistent use of macros
 + installs and runs without seg-faulting on i386 FC-5

I don't see any blockers here so its APPROVED.

Please fix the permissions on that one file before submitting 
the first build.
Comment 4 Mamoru TASAKA 2006-10-18 04:22:59 UTC 
Some notes from me:

Requires(post):   shared-mime-info, desktop-file-utils, scrollkeeper
Requires(postun): shared-mime-info, desktop-file-utils, scrollkeeper

All this requires should be for gnome-genius. Please fix this.
Comment 5 Rex Dieter 2006-10-18 12:10:00 UTC 
FYI, See: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
that no new dependancies (like for shared-mime-info or desktop-file-utils) 
need be added, so likely all you really want/need is:
Requires(post):   scrollkeeper
Requires(postun): scrollkeeper
Comment 6 Gérard Milmeister 2006-10-18 15:44:21 UTC 
I fixed the permissions and the Requires, and imported into cvs.
Comment 7 Gérard Milmeister 2006-10-19 15:27:26 UTC 
Built on FC5 and FC6.
Added entry to owners and comps files.

Thanks for the review.
Comment 8 Dominik 'Rathann' Mierzejewski 2006-11-18 22:29:41 UTC 
Good work! Please close it and remove from Extras/SIGs/SciTech proposals page.
Note You need to log in before you can comment on or make changes to this bug.