Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 212502 - Review Request: perl-Chatbot-Eliza - Clone of the classic Eliza program
Summary: Review Request: perl-Chatbot-Eliza - Clone of the classic Eliza program
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Patrice Dumas
QA Contact: Fedora Package Reviews List
URL: http://search.cpan.org/dist/Chatbot-E...
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-10-27 02:06 UTC by Chris Weyl
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-10-27 22:25:38 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Chris Weyl 2006-10-27 02:06:36 UTC 
SRPM URL: http://home.comcast.net/~ckweyl/perl-Chatbot-Eliza-1.04-1.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Chatbot-Eliza.spec

Description:
This module implements the classic Eliza algorithm. The original Eliza
program was written by Joseph Weizenbaum and described in the
Communications of the ACM in 1966. Eliza is a mock Rogerian
psychotherapist. It prompts for user input, and uses a simple
transformation algorithm to change user input into a follow-up question.
The program is designed to give the appearance of understanding.
Comment 1 Patrice Dumas 2006-10-27 07:38:23 UTC 
* rpmlint is silent
* free software, licence not included
* spec legible
* simple perl module, no BuildRequires needed
* match upstream
754199bbe591eaa11301aee108586fcd  Chatbot-Eliza-1.04.tar.gz
* sane provides
Provides: perl(Chatbot::Eliza) = 1.04

Needswork:

The language specific files in %doc should be tagged with the
appropriate %lang.

Comment:

Not a blocker, but I think that there could be a summary
explaining better what it the module does.
Comment 2 Chris Weyl 2006-10-27 16:37:40 UTC 
(In reply to comment #1)
> Needswork:
> 
> The language specific files in %doc should be tagged with the
> appropriate %lang.

Is this a blocker, given that they're sample files in %doc and named "deutsch"
and "norsk"?  Given that there's a couple sample files for those two languages,
I suppose I could put them under, %doc/DE and %doc/NO?  Would that suffice?
Comment 3 Patrice Dumas 2006-10-27 16:48:52 UTC 
No need to do that, I just ask for the following, instead of
a plain %doc:

%doc doctor.txt simple* README debug.cgi twobots
%lang(de) %doc deutsch*
%lang(??) %doc norsk*
Comment 4 Chris Weyl 2006-10-27 17:57:04 UTC 
(In reply to comment #3)
> No need to do that, I just ask for the following, instead of
> a plain %doc:
> 
> %doc doctor.txt simple* README debug.cgi twobots
> %lang(de) %doc deutsch*
> %lang(??) %doc norsk*

Done:

SRPM URL: http://home.comcast.net/~ckweyl/perl-Chatbot-Eliza-1.04-2.fc6.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Chatbot-Eliza.spec

Out of curiosity, what does tagging these files in this fashion do?  Looking at
the resulting rpm I'm not seeing any difference.
Comment 5 Patrice Dumas 2006-10-27 21:30:28 UTC 
(In reply to comment #4)
> Out of curiosity, what does tagging these files in this fashion do?  Looking at
> the resulting rpm I'm not seeing any difference.

I don't know what it should do, and I believe it does  nothing yet.


In the summary, I think the s of elisa should be a z.


APPROVED
Comment 6 Chris Weyl 2006-10-27 22:25:38 UTC 
(In reply to comment #5)
> In the summary, I think the s of elisa should be a z.

Fixed, thanks. 

> APPROVED

Imported & building for devel, branches requested for FC-5, FC-6.

Thanks for the review!
Note You need to log in before you can comment on or make changes to this bug.