Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 212503 - Review Request: perl-WWW-Babelfish - Perl extension for translation via Babelfish or Google
Summary: Review Request: perl-WWW-Babelfish - Perl extension for translation via Babel...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL: http://search.cpan.org/dist/WWW-Babel...
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-10-27 02:16 UTC by Chris Weyl
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-11-13 16:39:14 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Chris Weyl 2006-10-27 02:16:21 UTC 
SRPM URL: http://home.comcast.net/~ckweyl/perl-WWW-Babelfish-0.15-1.fc6.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-WWW-Babelfish.spec

Description:
Perl interface to the WWW babelfish translation server.
Comment 1 Jason Tibbitts 2006-11-13 15:44:47 UTC 
* source files match upstream:
   bc6293dabcbf5e96435fc8acaf8ac939  WWW-Babelfish-0.15.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(WWW::Babelfish) = 0.15
   perl-WWW-Babelfish = 0.15-1.fc7
  =
   perl >= 0:5.008
   perl(:MODULE_COMPAT_5.8.8)
   perl(AutoLoader)
   perl(Encode)
   perl(Exporter)
   perl(HTML::TokeParser)
   perl(HTTP::Request::Common)
   perl(IO::String)
   perl(LWP::UserAgent)
   perl(strict)
   perl(vars)
* %check is present and the single trivial test passes:
   1..1
   ok 1
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED
Comment 2 Chris Weyl 2006-11-13 16:39:14 UTC 
Imported, building for devel and FC-5,6 branches requested.

Thanks for the review! :)
Note You need to log in before you can comment on or make changes to this bug.