Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 212883 (php-pear-Net-URL) - Review Request: php-pear-Net-URL - Easy parsing of URLs
Summary: Review Request: php-pear-Net-URL - Easy parsing of URLs
Keywords:
Status: CLOSED NEXTRELEASE
Alias: php-pear-Net-URL
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT pear-HTTP-Request
TreeView+ depends on / blocked
 
Reported: 2006-10-29 22:39 UTC by Christopher Stone
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-11-07 23:48:39 UTC
Type: ---
Embargoed:
wtogami: fedora-cvs+


Attachments (Terms of Use)

Description Christopher Stone 2006-10-29 22:39:59 UTC
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Net-URL.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Net-URL-1.0.14-1.src.rpm

Description:
Provides easy parsing of URLs and their constituent parts.

Comment 1 Remi Collet 2006-11-05 17:40:52 UTC
Sorry, i've been a long time without looking at the packages waiting for review...
And i need this one, so i began to review some of them.

Comment 2 Remi Collet 2006-11-05 18:09:26 UTC
* source files match upstream:
4be5ac05dc5a9bc54a33cec66d87eb0a  SOURCES/Net_URL-1.0.14.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
  php-pear(Net_URL) = 1.0.14
  php-pear-Net-URL = 1.0.14-1.fc7
* %check is not present; no test suite provide.
* owns the directories it creates (Net already owned but by non-dependant rpm)
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear install)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

What do you think of adding CHANGELOG to the %doc (have a look at the
xml2changelod i used on my rpm) ?


Comment 3 Christopher Stone 2006-11-07 23:48:39 UTC
I need to look at your xml2changelog in more detail, unfortunately time is very
limited for me at the moment, reviews and review requests piling up on me. :(

Perhaps you can add something about it on the PHP Guidelines wiki page?


Comment 4 Christopher Stone 2007-04-25 22:13:07 UTC
Package Change Request
======================
Package Name: php-pear-Net-URL
New Branches: EL-5


Note You need to log in before you can comment on or make changes to this bug.