Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 213765 - Review Request: alex4 - Alex the Allegator 4 - Platform game
Summary: Review Request: alex4 - Alex the Allegator 4 - Platform game
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Paul F. Johnson
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-11-02 21:46 UTC by Hans de Goede
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-11-03 15:52:39 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Hans de Goede 2006-11-02 21:46:57 UTC 
Spec URL: http://people.atrpms.net/~hdegoede/alex4.spec
SRPM URL: http://people.atrpms.net/~hdegoede/alex4-1.0-1.src.rpm
Description:
In the latest installment of the series Alex travels through the jungle in
search of his kidnapped girlfriend. Plenty of classic platforming in four
nice colors guaranteed!

---

Hmm I just realised this needs work to work properly on PPC (I had to fix some file loading issues on x86_64, but there are endian issues in there too I realise now).

I'll report back here with an updated version for PPC soon.
Comment 1 Paul F. Johnson 2006-11-02 22:31:38 UTC 
Two quickies.

1. why no _smp_mflags on the make? If it's down to a race condition, can you
comment it please

2.   --add-category X-Fedora  is causing problems for me big style on rawhide.
if you enclose it with a conditional that the branch of fedora is < "7", then
I'm happy

rpmlint is quiet, so that's good :)
Comment 2 Paul F. Johnson 2006-11-03 08:23:18 UTC 
rpmlint is quiet
builds fine in mock

Review - note, that you'll need something for #1 before it's approved (though
you can ignore my first comment - I've just seen the smp_mflags!)

Good
spec file clear and in US English
upstream md5 and package md5 are the same
license good
consistent use of macros
permissions fine
update-icon-cache fine
files permissions good
package includes documentation
no-devel package required
package installs and runs fine (x86 and x86_64) - minimal test though

needs work
--add-category X-Fedora annoys the buildsys for rawhide

Fix the needs work and it's good to go.
Comment 3 Hans de Goede 2006-11-03 13:37:27 UTC 
Thanks for the review!

(In reply to comment #2)
> needs work
> --add-category X-Fedora annoys the buildsys for rawhide
> 

That is no longer a problem as there has been a new desktop-file-utils system in
rawhide for a few days now which fixes this.

> Fix the needs work and it's good to go.

Well what did really need fixing where the endian issues I already reported,
here is a new version with those fixed (no other changes were made):
Spec URL: http://people.atrpms.net/~hdegoede/alex4.spec
SRPM URL: http://people.atrpms.net/~hdegoede/alex4-1.0-2.src.rpm
Comment 4 Paul F. Johnson 2006-11-03 14:59:19 UTC 
It looks good at this end.

APPROVED
Comment 5 Hans de Goede 2006-11-03 15:52:39 UTC 
Thanks! Imported and build, closing.
Note You need to log in before you can comment on or make changes to this bug.