Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 2162931 - Review Request: python-wordcloud - A little word cloud generator
Summary: Review Request: python-wordcloud - A little word cloud generator
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2023-01-22 03:03 UTC by Davide Cavalca
Modified: 2023-01-25 02:35 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2023-01-22 23:00:53 UTC
Type: ---
michel: fedora-review+

Attachments (Terms of Use)
The .spec file difference from Copr build 5282333 to 5283167 (deleted)
2023-01-22 22:34 UTC, Jakub Kadlčík
no flags Details | Diff

Description Davide Cavalca 2023-01-22 03:03:02 UTC
Spec URL:

This package provides a little word cloud generator in Python.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2023-01-22 03:03:04 UTC
This package built on koji:

Comment 3 Michel Lind 2023-01-22 19:04:41 UTC
- Package must not depend on deprecated() packages.
  Note: python3-mock is deprecated, you must not depend on it.

see - please replace occurences of mock with unittest.mock, drop mock from requirements-dev.txt and ideally send a PR upstream

Comment 4 Davide Cavalca 2023-01-22 22:28:07 UTC
Spec URL:

- drop python-mock BR as it's only used in the disabled test (which is broken for other reasons)

Comment 5 Jakub Kadlčík 2023-01-22 22:34:47 UTC
Created attachment 1939884 [details]
The .spec file difference from Copr build 5282333 to 5283167

Comment 7 Michel Lind 2023-01-22 22:43:03 UTC
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT License", "Unknown or generated", "*No copyright* MIT
     License", "*No copyright* Public domain", "*No copyright* [generated
     file]". 20 files have unknown license. Detailed output of licensecheck
     in /var/lib/copr-rpmbuild/results/python-wordcloud/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

[x]: Python eggs must not download any dependencies during the build
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

[x]: Reviewer should test that the package builds in mock.
[!]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.

Checking: python3-wordcloud-
============================ rpmlint session starts ============================
rpmlint: 2.4.0
rpmlintrc: [PosixPath('/tmp/tmp611eet71')]
checks: 31, packages: 3

python3-wordcloud.x86_64: W: no-manual-page-for-binary wordcloud_cli
 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s 

Rpmlint (installed packages)
============================ rpmlint session starts ============================
rpmlint: 2.4.0
checks: 31, packages: 2

python3-wordcloud.x86_64: W: no-manual-page-for-binary wordcloud_cli
 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.1 s 

Unversioned so-files
python3-wordcloud: /usr/lib64/python3.11/site-packages/wordcloud/

Source checksums
---------------- :
  CHECKSUM(SHA256) this package     : 71f1b85f0a837d15ac9193e9aec2d6e3095bcaecf930e9f93eea9ecebe2f0396
  CHECKSUM(SHA256) upstream package : 71f1b85f0a837d15ac9193e9aec2d6e3095bcaecf930e9f93eea9ecebe2f0396 :
  CHECKSUM(SHA256) this package     : 4d78b94ecb8a5b37a153c67b15d328fb91e0f93edb608c5515d897a6f824eb1f
  CHECKSUM(SHA256) upstream package : 4d78b94ecb8a5b37a153c67b15d328fb91e0f93edb608c5515d897a6f824eb1f :
  CHECKSUM(SHA256) this package     : 523db887e47e840eb5c2e60428243bb1d7439fdc60f89626b17bafa1be64459c
  CHECKSUM(SHA256) upstream package : 523db887e47e840eb5c2e60428243bb1d7439fdc60f89626b17bafa1be64459c

python3-wordcloud (rpmlib, GLIBC filtered):

python-wordcloud-debugsource (rpmlib, GLIBC filtered):



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name python-wordcloud --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, C/C++, Python, Shell-api
Disabled plugins: SugarActivity, PHP, Java, Perl, R, Haskell, fonts, Ocaml

Comment 8 Fedora Admin user for bugzilla script actions 2023-01-22 22:43:54 UTC
The Pagure repository was created at

Comment 9 Fedora Update System 2023-01-22 23:00:03 UTC
FEDORA-2023-2b7263affe has been submitted as an update to Fedora 38.

Comment 10 Fedora Update System 2023-01-22 23:00:53 UTC
FEDORA-2023-2b7263affe has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2023-01-23 00:35:56 UTC
FEDORA-2023-fbb955dd0f has been submitted as an update to Fedora 37.

Comment 12 Fedora Update System 2023-01-23 00:36:06 UTC
FEDORA-2023-99c173ba9b has been submitted as an update to Fedora 36.

Comment 13 Fedora Update System 2023-01-25 01:47:03 UTC
FEDORA-2023-fbb955dd0f has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2023-01-25 02:35:56 UTC
FEDORA-2023-99c173ba9b has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.