Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2168973 - Review Request: rust-time-core - Internal implementation details of the 'time' crate
Summary: Review Request: rust-time-core - Internal implementation details of the 'time...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: blinxen
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/time-core
Whiteboard:
Depends On:
Blocks: 2137245
TreeView+ depends on / blocked
 
Reported: 2023-02-10 19:40 UTC by Fabio Valentini
Modified: 2023-02-20 01:36 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-02-20 01:36:08 UTC
Type: ---
Embargoed:
h-k-81: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-02-10 19:40:20 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-time-core.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-time-core-0.1.0-1.fc37.src.rpm

Description:
Internal implementation details of the 'time' crate.

Fedora Account System Username: decathorpe

koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=97351384

Comment 1 Jakub Kadlčík 2023-02-10 19:46:31 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5516510
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2168973-rust-time-core/fedora-rawhide-x86_64/05516510-rust-time-core/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 blinxen 2023-02-12 20:48:58 UTC
This is my first formal review. But because the spec file was generated with rust2rpm, the review should pretty straightforward.

Review:

- The generated "review.txt" file did not contain any issues
- The package can be built and installed in rawhide without issues
- License files are present and referenced via %license macro
- Latest version is packaged
- Package complies with the rust packaging guidelines 


In the scratch build, the s390x [1] build did not go off. But this was probably due to the planned outage of the s390x builders.

Package APPROVED.

[1] https://koji.fedoraproject.org/koji/taskinfo?taskID=97351449

Comment 3 Fabio Valentini 2023-02-13 00:24:23 UTC
Awesome, thanks for the review!

Comment 4 Fedora Admin user for bugzilla script actions 2023-02-13 00:24:47 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-time-core


Note You need to log in before you can comment on or make changes to this bug.