Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 218232 (pear-Math-Stats) - Review Request: php-pear-Math-Stats - Classes to calculate statistical parameters
Summary: Review Request: php-pear-Math-Stats - Classes to calculate statistical parame...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: pear-Math-Stats
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michał Bentkowski
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-12-03 22:58 UTC by Christopher Stone
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-01-03 18:04:29 UTC
Type: ---
Embargoed:
wtogami: fedora-cvs+


Attachments (Terms of Use)

Description Christopher Stone 2006-12-03 22:58:00 UTC
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Math-Stats.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Math-Stats-0.9.0-0.1.beta3.src.rpm

Description:
Package to calculate statistical parameters of numerical arrays
of data. The data can be in a simple numerical array, or in a
cummulative numerical array. A cummulative array, has the value
as the index and the number of repeats as the value for the
array item, e.g. $data = array(3=>4, 2.3=>5, 1.25=>6, 0.5=>3).

Comment 1 Josef Bacik 2006-12-27 20:13:38 UTC
[jwhiter@dhcp59-101 ~]$ 
rpmlint /home/jwhiter/redhat/RPMS/noarch/php-pear-Math-Stats-0.9.0-0.1.beta3.noarch.rpm 
W: php-pear-Math-Stats non-standard-dir-in-usr doc 
[jwhiter@dhcp59-101 ~]$  

I'm assuming thats ok since you are putting the doc into a php-pear doc 
directory.

Everything else looks good.  As this is my first review I'm going to wait on 
feedback for the rpmlint error before approving this.

Comment 2 Josef Bacik 2006-12-27 21:20:14 UTC
Ok everything looks good, here is my review check list.

review check:
 
 -rpmlint output:

[jwhiter@dhcp59-101 ~]$ 
rpmlint /home/jwhiter/redhat/RPMS/noarch/php-pear-Math-Stats-0.9.0-0.1.beta3.noarch.rpm 
[jwhiter@dhcp59-101 ~]$  
 
 - package is named according to the php package naming guidelines
 - spec file name matches %{name}
 - package meets package guidlines
 - package is licensed with appropriate open source license
 - license feild matches actual license
 - license is in %doc
 - license file is written in american english
 - spec file is legible
 - sources match upstream
   ffc0b653e5e2985113262a5299ebe69b  Math_Stats-0.9.0beta3.tgz
 - package successfully compiled on fc6 x86_64 box
 - buildrequires makes sense and everything required is present
 - no locales
 - no shared libraries
 - not relocatable
 - owns all directories it creates 
 - no duplicates in %files
 - permissions set properly
 - contains a %clean section
 - uses macros consistently 
 - contains code
 - no large documentation
 - files in %doc do not affect runtime
 - no header files or static libraries
 - no pkgconfig files
 - no dynamic libraries provided by package, no need for -devel package
 - no .la files
 - not a GUI application
 - does not own files or directories owned by other packages

sorry about the rpmlint problem before, I hadn't run fedora-buildrpmtree on 
the box I was building on.

Comment 3 Josef Bacik 2007-01-02 22:06:47 UTC
chris - since you haven't sponsored me yet, is this supposed to be assigned to 
me?  If it is, am i supposed to move this into FE-ACCEPT?  If not what do you 
need me to do?

Comment 4 Christopher Stone 2007-01-02 22:29:42 UTC
The bug should still block FE-NEW and be assigned to nobody
(or whatever the default asignee is)

Comment 5 Michał Bentkowski 2007-01-03 17:39:59 UTC
Review:
 * rpmlint is quiet (and that's good ;-))
 * I have no objection to names of package and spec file
 * sources match upstream (md5: ffc0b653e5e2985113262a5299ebe69b)
 * package is licensed under PHP open-source compatible license which is
properly mentioned in License field and included in %doc
 * no problems with building on fc6/x86_64
 * package isn't designed to be relocatable
 * %post and %postun are present (like in a template)
 * package meets every Guidelines it should
 * everything looks very similar to a php-pear spec template and
everything is good :)

There's even no need to set a FE-REVIEW blocker.
Me and everything else can say that:
 ___________
< Approved! >
 -----------
       \   ,__,
        \  (oo)____
           (__)    )\
              ||--|| *


Comment 6 Christopher Stone 2007-01-03 18:04:29 UTC
- Imported into CVS
- Entry added to owners.list
- Tagged and Built on devel
- FC-5/6 branch request made

Thanks for the review!

Comment 7 Christopher Stone 2007-05-01 02:23:00 UTC
Package Change Request
======================
Package Name: php-pear-Math-Stats
New Branches: EL-5


Note You need to log in before you can comment on or make changes to this bug.