Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 218831 - Review Request: python-urljr - A common interface to urllib2 and curl for making HTTP requests
Summary: Review Request: python-urljr - A common interface to urllib2 and curl for mak...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michał Bentkowski
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: 218787
Blocks: FE-ACCEPT 218844 218852
TreeView+ depends on / blocked
 
Reported: 2006-12-07 18:52 UTC by Jeffrey C. Ollie
Modified: 2007-12-16 17:33 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-12-12 05:02:33 UTC
Type: ---
Embargoed:
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Jeffrey C. Ollie 2006-12-07 18:52:18 UTC 
Spec URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/python-urljr-1.0.1-1.fc6.spec
SRPM URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/python-urljr-1.0.1-1.fc6.src.rpm
Description:

URL-related utilities from JanRain, Inc. This package contains the
"fetchers" module, which provides a common interface to urllib2 and
curl for making HTTP requests.
Comment 1 Michał Bentkowski 2006-12-08 17:51:30 UTC 
I'll review it :)
Comment 2 Michał Bentkowski 2006-12-08 18:09:47 UTC 
MUST items:
 * rpmlint is quiet
 * package is named well
 * spec file name is good
 * package meets Packaging Guidelines
 * package is licensed with an LGPL open-source compatible license
 * License field in spec file matches actual license
 * license file isn't included in %doc
 * md5sums are matching (0b120d08dc4538ed5c4ee5c77447b865)
 * BuildRequires listed well
 * no locales
 * no need to %post and %postun sections
 * not relocatable
 * package owns directories well
 * no duplicates in %files
 * %files section includes %defattr 
 * proper %clean section
 * macros used well

In fact, license file isn't included as a COPYING file contains only information
about license, not the license itself. However, guidelines say that:
"If (and only if) the source package includes the text of the license(s) in its 
wn file, then that file, containing the text of the license(s) for the package
must be included in %doc." so it's not a blocker.

Package is approved :)
Comment 3 Michał Bentkowski 2006-12-10 17:48:48 UTC 
I see package in CVS, but you haven't even tried to rebuild it, why?
Comment 4 Jeffrey C. Ollie 2006-12-10 18:13:38 UTC 
python-urljr depends on python-pycurl.  python-pycurl in development needs to be
updated to a CVS snapshot since curl in development is newer than curl in FC <=
6.  I'm waiting for the python-pycurl to be branched for FC-5 and FC-6 to
upgrade development to the CVS snapshot (FC-5 and FC-6 will stick with the
released version that was reviewed).
Comment 5 Jeffrey C. Ollie 2006-12-12 05:02:33 UTC 
OK, now that python-pycurl has been built, I've pushed builds for python-urljr.
 They should be available in the next push.
Comment 6 Jeffrey C. Ollie 2007-12-15 22:16:46 UTC 
Package Change Request
======================
Package Name: python-urljr
New Branches: EL-4 EL-5
Updated EPEL Owners: jcollie
Comment 7 Kevin Fenzi 2007-12-16 17:33:02 UTC 
cvs done.
Note You need to log in before you can comment on or make changes to this bug.