Jeffrey, I'll try to do a review of this package and the ones it blocking,
however, the first thing I noticed that the versioning for the package is not
correct.  Please take a look at:
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-e104844825856d7c45f2f0241586985c0495966b

Spec URL:
http://repo.ocjtech.us/misc/fedora/6/SRPMS/pyflakes-0.0-1.10526svn.fc6.spec
SRPM URL:
http://repo.ocjtech.us/misc/fedora/6/SRPMS/pyflakes-0.0-1.10526svn.fc6.src.rpm

That should fix the naming problem...

Is this a pre-release of 0.2.1 or a snapshot post 0.2.1?

It's post 0.2.1 - I didn't see the old web page at
http://divmod.org/projects/pyflakes before creating these packages so I guess I
just assumed that there hadn't been a release.

Check me on this, but I believe it would then be considered a snapshot release,
and your version numbering would need to be different based off the prior
release number.  See
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-cfd71146dbb6f00cec9fe3623ea619f843394837

Perhaps you want to revert to the released package.

Either way, fix it up, and I'll review.

I'll stick with the SVN snapshot since it's what I've tested with.

Spec URL:
http://repo.ocjtech.us/misc/fedora/6/SRPMS/pyflakes-0.2.1-1.10526svn.fc6.spec
SRPM URL:
http://repo.ocjtech.us/misc/fedora/6/SRPMS/pyflakes-0.2.1-1.10526svn.fc6.src.rpm

SVN/CVS versions are generally frowned upon unless they provide significant bug
fixes (that would not be easily provided with patch) or significant features or
functionality that dependent packages rely on.

I would prefer that you first verify against the release version if you are
providing such fixes are features before we take the path of introducing a
snapshot into FE.

Spec URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/pyflakes-0.2.1-2.fc6.spec
SRPM URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/pyflakes-0.2.1-2.fc6.src.rpm

Switching to released tarball

The package builds cleanly with a mock-build on FC6.  There is one minor rpmlint
complaint that should be fixed:

rpmlint -i pyflakes-0.2.1-2.fc6.src.rpm 
W: pyflakes mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 12)
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance.  Use either spaces or tabs for indentation, not both.

No tabs please.


MUST Items:
- MUST: The License field in the package spec file must match the actual license.

This is the MIT license.

Spec URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/pyflakes-0.2.1-3.fc6.spec
SRPM URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/pyflakes-0.2.1-3.fc6.src.rpm

License fixed... Thanks, all the different licenses confuse me!

I see you fixed the lint output as well.

This ends my review of the package.

Bernard, do you have the reviewer bits set on your Fedora account?  If yes,
could you set the status and assignment of this package according to the
result/phase of your review as documented at
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

Ville

I don't have a Fedora account since I haven't been sponsored yet.  I forgot to
state that this was an unofficial review, but Jeffrey knew that because I was
providing several unofficial reviews for his packages.

Sorry for the confusion.

I hope you don't mind if I finish this.

+ License (MIT)
+ BuildArch noarch
+ follows python template
+ macro usage
+ source matches
+ follows naming guidelines
+ sane BuildRoot
+ runs

APPROVED

Thanks for the review... imported, built for devel, branches requsted for FC-5
and FC-6.

Package Change Request
======================
Package Name: pyflakes
New Branches: EL-4 EL-4
Updated EPEL Owners: jcollie

cvs done.