Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 219103 - Review Request: dvdauthor - Command line DVD authoring tool
Summary: Review Request: dvdauthor - Command line DVD authoring tool
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Dominik 'Rathann' Mierzejewski
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-12-10 22:19 UTC by Ville Skyttä
Modified: 2012-04-25 13:42 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-01-07 14:22:41 UTC
Type: ---
Embargoed:
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Ville Skyttä 2006-12-10 22:19:23 UTC 
http://cachalot.mine.nu/6/SRPMS/dvdauthor.spec
http://cachalot.mine.nu/6/SRPMS/dvdauthor-0.6.11-8.cmn6.src.rpm

dvdauthor is a program that will generate a DVD movie from a valid
mpeg2 stream that should play when you put it in a DVD player.
Comment 1 Ville Skyttä 2006-12-10 22:21:09 UTC 
spot, I think it wouldn't hurt to look at this from the FE-Legal POV as the
package touches the DVD and MPEG areas.  Could you have a look?
Comment 2 Parag AN(पराग) 2006-12-11 04:27:00 UTC 
Better to have a dicussion on FE mailing list.
Comment 3 Dominik 'Rathann' Mierzejewski 2006-12-12 12:56:40 UTC 
I'll try to review this once legal doubts are cleared.
Comment 4 Tom "spot" Callaway 2007-01-07 04:54:40 UTC 
OK, so in looking at this:

- dvdauthor can't encode mpeg
- dvdauthor can't decode mpeg
- dvdauthor can't play mpeg (duh, it can't encode/decode)
- dvdauthor can mux/demux mpeg (this is how it gets into DVD format)
- dvdauthor can't decode encrypted DVDs

Since mux/demux is ok, this should be ok for Fedora. Lifting FE-Legal.
Comment 5 Dominik 'Rathann' Mierzejewski 2007-01-07 13:58:50 UTC 
 1. package meets naming and packaging guidelines.
 2. specfile is properly named, is cleanly written and uses macros consistently.
 3. dist tag is present.
 4. build root is correct.
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 5. license field matches the actual license.
 6. license is open source-compatible (GPL). License text included in package.
 7. source files match upstream:
    d2c45879e4cfb95d410bf603af891e07  dvdauthor-0.6.11.tar.gz
 8. latest version is being packaged.
 9. BuildRequires are proper.
10. package builds in mock (x86_64 devel).
11. rpmlint is silent.
12. final provides and requires are sane:

dvdauthor = 0.6.11-8.fc7
=
/bin/sh  
libc.so.6()(64bit)  
libdvdread.so.3()(64bit)  
libfreetype.so.6()(64bit)  
libfribidi.so.0()(64bit)  
libm.so.6()(64bit)  
libpng12.so.0()(64bit)  
libxml2.so.2()(64bit)  
libz.so.1()(64bit)  

13. no shared libraries are present.
14. package is not relocatable.
15. owns the directories it creates.
16. doesn't own any directories it shouldn't.
17. no duplicates in %files.
18. file permissions are appropriate.
19. %clean is present.
20. %check is not present and no testsuite.
21. no scriptlets present.
22. code, not content.
23. documentation is small, so no -docs subpackage is necessary.
24. %docs are not necessary for the proper functioning of the package.
25. no headers.
26. no pkgconfig files.
27. no libtool .la droppings.
28. not a GUI app.
29. not a web app.

APPROVED.
Comment 6 Dominik 'Rathann' Mierzejewski 2007-01-07 14:00:35 UTC 
Oops forgot to set ASSIGNED.
Comment 7 Ville Skyttä 2007-01-07 14:22:41 UTC 
Devel build done, owners.list and comps-fe7 updated, FC-6 branch requested.  Thanks!
Comment 8 Richard Shaw 2012-04-25 13:26:39 UTC 
Package Change Request
======================
Package Name: dvdauthor
New Branches: el6
Owners: hobbes1069
InitialCC:
Comment 9 Gwyn Ciesla 2012-04-25 13:42:05 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.