Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 220730 - Review Request: gpodder - Podcast receiver/catcher written in Python
Summary: Review Request: gpodder - Podcast receiver/catcher written in Python
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Brian Pepple
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-12-24 23:15 UTC by Jef Spaleta
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-12-28 06:48:15 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Jef Spaleta 2006-12-24 23:15:00 UTC
Spec URL: 
http://jspaleta.thecodergeek.com/Fedora%20SRPMS/gpodder/gpodder.spec

SRPM URL: http://jspaleta.thecodergeek.com/Fedora%20SRPMS/gpodder/gpodder-0.8.0-2.src.rpm

Description: <description here>
gPodder is a Podcast receiver/catcher written in Python, using GTK.
It manages podcast feeds for you and automatically downloads all
podcasts from as many feeds as you like.
It also optionally supports syncing with ipods.

Comment 1 Brian Pepple 2006-12-26 16:37:21 UTC
Jef, I'll get you a review for this later today.

Comment 2 Brian Pepple 2006-12-26 22:11:54 UTC
MD5Sum:
8c58c613d049bd2387e09876c574ebf9  gpodder-0.8.0.tar.gz

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed.
* Files have appropriate permissions and owners
* Rpmlint produces no warnings or errors.
* Package builds in Mock fine.
* Package installs and uninstalls cleanly on FC6
* Package seems to work fine, based on a quick test.

Minor Items that should be fixed before building in FE:
* Drop the 'X-Fedora-Extras' category from the desktop file.  It was recently
decided to drop the 'X-Fedora' & 'X-Fedora-Extras' categories.  Refer to the
example at
http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755
* Drop the Requires on Python, since it is redundant.  The BR on python-devel
will provide python(abi) = 2.4 automatically.  Refer to your build logs for
verification.

Minor:
* Close button on about window does not work.  This isn't a blocker, but
probably at a minimum should be reported upstream.

+1 APPROVE

Comment 3 Jef Spaleta 2006-12-28 06:48:15 UTC
Built in the development tree awaiting signing.



Comment 4 Christian Iseli 2007-01-02 23:33:41 UTC
Changed summary for tracking purposes.



Note You need to log in before you can comment on or make changes to this bug.