Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 220999 (pear-Net-Sieve) - Review Request: php-pear-Net-Sieve - Communication with timsieved
Summary: Review Request: php-pear-Net-Sieve - Communication with timsieved
Alias: pear-Net-Sieve
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Christopher Stone
QA Contact: Fedora Package Reviews List
Depends On:
Blocks: FE-ACCEPT 220926
TreeView+ depends on / blocked
Reported: 2006-12-30 06:15 UTC by Brandon Holbrook
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2006-12-31 05:58:58 UTC
Type: ---

Attachments (Terms of Use)

Description Brandon Holbrook 2006-12-30 06:15:01 UTC
Spec URL:

Provides an API to talk to the timsieved server that comes with Cyrus IMAPd.
Can be used to install, remove, mark active, etc sieve scripts.

Comment 1 Christopher Stone 2006-12-30 06:42:53 UTC
I'll review this (probably tomorrow).  Two second glance at spec looks like you
have the wrong license.

Comment 2 Christopher Stone 2006-12-30 06:47:33 UTC
Brandon, I'm seeing a couple little minor things that need fixing.  Could you
please redo this spec using the fedora-newrpmspec command?  Just run
fedora-newrpmsepc php-pear-Net-Sieve and it will create a default template for
you to use.  This will be much easier for me to review.  Thanks.

Comment 3 Brandon Holbrook 2006-12-30 06:54:55 UTC
I don't mind regenerating a new spec file, but this one is almost verbatim the
pear template found at:

If something is wrong with the template I'd rather point out specifics so the
wiki can be updated as well as this package.

Comment 4 Christopher Stone 2006-12-30 16:27:07 UTC
Fixed.  Thanks for pointing this out.

Comment 5 Brandon Holbrook 2006-12-30 22:45:55 UTC
Spec URL:

Cleaned up to match the new template.  Thanks for updating it Chris!

Comment 6 Brandon Holbrook 2006-12-30 22:51:51 UTC
I also changed the license to BSD (at least that's what it looked like in the
header comment in Sieve.php)

Comment 7 Christopher Stone 2006-12-31 00:04:00 UTC
- rpmlint output:
W: php-pear-Net-Sieve no-documentation
permissible, no documentation
- package named according to package naming guidelines
- spec filename matches %{name}
- package meets packaging guidelines
- licensed with open source compatible license
- license matches actual license
- source package does not include license file
- spec written in American english
- spec file is legible
- package successfully compiles and builds on FC6 x86_64
- all build dependices listed in BR
- no locales
- no shared libraries
- package is not relocatable
- packge owns all directories it creates
- no duplicates in %files
- file permissions set properly
- package contains proper %clean section
- macro usage is consistent
- contains code
- no large documentation
- no %doc
- no header files or static libraries
- no pkgconfig files
- no library files
- no need for devel subpackage
- no .la files
- not a GUI app needing a .desktop file
- packages shares directory ownership with other Net packages.  Acceptable for
pear packages


Comment 8 Christopher Stone 2006-12-31 00:05:33 UTC
oops forgot one checklist item:
- sources match upstream
2f0b868d5bde1742721d525233274f5a  Net_Sieve-1.1.5.tgz


Comment 9 Brandon Holbrook 2006-12-31 05:58:58 UTC
Thanks again Chris.

Imported, built, FC[56] branches requested

Note You need to log in before you can comment on or make changes to this bug.