Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 221947 - Review Request: gwenhywfar - utility library
Summary: Review Request: gwenhywfar - utility library
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2007-01-09 06:25 UTC by Bill Nottingham
Modified: 2014-03-17 03:04 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-06-09 03:59:38 UTC
Type: ---
Embargoed:
j: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Bill Nottingham 2007-01-09 06:25:35 UTC
Spec URL: http://people.redhat.com/notting/review/gwenhywfar.spec
SRPM URL: http://people.redhat.com/notting/review/gwenhywfar-2.3.0-5.src.rpm
Description: gwenhywfar utility library

gwenhywfar is a utility library used by aqbanking. This is part of reviewing the gnucash stack.

Comment 1 Parag AN(पराग) 2007-01-10 07:47:10 UTC
rpmlint is not silent
rpmlint on main RPM reported
W: gwenhywfar non-conffile-in-etc /etc/gwen-public-ca.crt
A non-executable file in your package is being installed in /etc, but is not
a configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

rpmlint on -devel rpm reported
I: gwenhywfar-devel checking
E: gwenhywfar-devel only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.

Otherwise mock build is fine.

Comment 2 Bill Nottingham 2007-01-10 14:35:11 UTC
(In reply to comment #1)
> W: gwenhywfar non-conffile-in-etc /etc/gwen-public-ca.crt

It's not really a configuration file, it's a data file. It's a CA certificate
bundle, much like /etc/pki/tls/certs/ca-bundle.crt. However, that is
also marked %config, so I'll change this.

(Ideally it just uses the openssl CA bundle.)

> E: gwenhywfar-devel only-non-binary-in-usr-lib
> There are only non binary files in /usr/lib so they should be in /usr/share.

This is a mis-error from rpmlint. It's a architecture-specific include, so it
can't be in /usr/include, and needs to be in an architecture specific directory.
 See glib2, dbus, gcc, qt for other examples of this.


Comment 3 Paul Howarth 2007-01-10 15:28:00 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > W: gwenhywfar non-conffile-in-etc /etc/gwen-public-ca.crt
> 
> It's not really a configuration file, it's a data file. It's a CA certificate
> bundle, much like /etc/pki/tls/certs/ca-bundle.crt. However, that is
> also marked %config, so I'll change this.

Perhaps it should live in /etc/pki/tls/certs too?


Comment 4 Bill Nottingham 2007-01-10 17:03:55 UTC
It's not easily modifiable without patching, and if I'm going to do that, I'd
rather just patch it to *use* the openssl one. Currently discussing that w/upstream.

Comment 5 Paul Howarth 2007-01-10 17:12:02 UTC
FWIW, curl uses the openssl one rather than the one shipped in the curl tarball...

Comment 6 Bill Nottingham 2007-01-11 22:54:53 UTC
2.3.0-6 uploaded; cert bundle marked as config, rpaths fixed.

Comment 7 Parag AN(पराग) 2007-01-12 06:52:21 UTC
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM.
- rpmlint is NOT silent for RPMS.
E: gwenhywfar-devel only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.
But its ok as it looks mis-error by rpmlint.

+ source files match upstream.
0f7cf7d0efa6719f85c00d6d8ccec2b3  gwenhywfar-2.3.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code Not contents.
+ no static libraries present.
+ no gwenhywfar.pc files present.
+ -devel subpackage exists
+ included
  %post -p /sbin/ldconfig
  %postun -p /sbin/ldconfig
+ no .la files.
+ translations are available
+ Dose owns the directories it creates.
+ no duplicates in %files.
+ no scriptlets used.
+ file permissions are appropriate.
APPROVED.



Comment 8 Bill Nottingham 2007-01-12 15:04:07 UTC
Just looking over:

(In reply to comment #7)
> + no gwenhywfar.pc files present.

It certainly has them in my builds...


Comment 9 Parag AN(पराग) 2007-01-12 15:22:12 UTC
(In reply to comment #8)
> Just looking over:
> 
> (In reply to comment #7)
> > + no gwenhywfar.pc files present.
> 
> It certainly has them in my builds...
oops Sorry. I actually used to copy my Review Template and modify them according
to package. I forgot to remove no word.





Comment 10 Parag AN(पराग) 2007-02-22 05:09:02 UTC
Ping
any problem for importing this package to CVS?

Comment 11 Bill Nottingham 2007-02-22 16:16:37 UTC
Just waiting for the round tuits. Will get to it this week-ish.

Comment 12 Bill Nottingham 2007-03-19 19:32:04 UTC
This is built now.

Comment 13 Bill Nottingham 2007-06-09 01:17:18 UTC
Package Change Request
======================
Package Name: gwenhywfar
New Branches: EL-4 EL-5



Comment 14 Jason Tibbitts 2007-06-09 03:59:38 UTC
CVS done.


Note You need to log in before you can comment on or make changes to this bug.