Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2240614 - Review Request: rust-relative-path - Portable, relative paths for Rust
Summary: Review Request: rust-relative-path - Portable, relative paths for Rust
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: blinxen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2219708
TreeView+ depends on / blocked
 
Reported: 2023-09-25 14:39 UTC by Fabio Valentini
Modified: 2023-10-04 22:10 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-10-04 22:10:27 UTC
Type: ---
Embargoed:
h-k-81: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-09-25 14:39:28 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-relative-path.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-relative-path-1.9.0-1.fc39.src.rpm

Description:
Portable, relative paths for Rust.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-09-25 14:39:30 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=106689902

Comment 2 blinxen 2023-09-27 23:25:28 UTC
Taking this review

General comments:

- Package was generated with rust2rpm and "-a" was added to all cargo macros


APPROVED


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Cannot run licensecheck: Command 'licensecheck -r
     /var/lib/mock/fedora-
     rawhide-x86_64/root/builddir/build/BUILD/relative-path-1.9.0' returned
     non-zero exit status 2.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
     relative-path-devel , rust-relative-path+default-devel , rust-
     relative-path+serde-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.


Rpmlint
-------
Checking: rust-relative-path-devel-1.9.0-1.fc40.noarch.rpm
          rust-relative-path+default-devel-1.9.0-1.fc40.noarch.rpm
          rust-relative-path+serde-devel-1.9.0-1.fc40.noarch.rpm
          rust-relative-path-1.9.0-1.fc40.src.rpm
============================================================================================================ rpmlint session starts ============================================================================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp6unuv2jp')]
checks: 31, packages: 4

rust-relative-path+default-devel.noarch: W: no-documentation
rust-relative-path+serde-devel.noarch: W: no-documentation
============================================================================= 4 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.2 s =============================================================================




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 3

rust-relative-path+serde-devel.noarch: W: no-documentation
rust-relative-path+default-devel.noarch: W: no-documentation
 3 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.0 s



Source checksums
----------------
https://crates.io/api/v1/crates/relative-path/1.9.0/download#/relative-path-1.9.0.crate :
  CHECKSUM(SHA256) this package     : c707298afce11da2efef2f600116fa93ffa7a032b5d7b628aa17711ec81383ca
  CHECKSUM(SHA256) upstream package : c707298afce11da2efef2f600116fa93ffa7a032b5d7b628aa17711ec81383ca


Requires
--------
rust-relative-path-devel (rpmlib, GLIBC filtered):
    cargo

rust-relative-path+default-devel (rpmlib, GLIBC filtered):
    cargo
    crate(relative-path)

rust-relative-path+serde-devel (rpmlib, GLIBC filtered):
    (crate(serde/default) >= 1.0.160 with crate(serde/default) < 2.0.0~)
    cargo
    crate(relative-path)



Provides
--------
rust-relative-path-devel:
    crate(relative-path)
    rust-relative-path-devel

rust-relative-path+default-devel:
    crate(relative-path/default)
    rust-relative-path+default-devel

rust-relative-path+serde-devel:
    crate(relative-path/serde)
    rust-relative-path+serde-devel


Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review --name rust-relative-path
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic
Disabled plugins: R, Haskell, Java, PHP, SugarActivity, Perl, fonts, Ocaml, Python, C/C++
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comment 3 Fedora Update System 2023-10-04 22:07:59 UTC
FEDORA-2023-c8bdf87a0a has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c8bdf87a0a

Comment 4 Fedora Update System 2023-10-04 22:10:27 UTC
FEDORA-2023-c8bdf87a0a has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.