Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2241238 - Review Request: rust-gstreamer-gl-wayland-sys - FFI bindings to libgstgl-1.0 (Wayland support)
Summary: Review Request: rust-gstreamer-gl-wayland-sys - FFI bindings to libgstgl-1.0 ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2241235
Blocks: 2241239
TreeView+ depends on / blocked
 
Reported: 2023-09-28 19:30 UTC by Kalev Lember
Modified: 2023-09-28 21:55 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-09-28 21:55:44 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Kalev Lember 2023-09-28 19:30:55 UTC
Spec URL: https://kalev.fedorapeople.org/rust-gstreamer-gl-wayland-sys.spec
SRPM URL: https://kalev.fedorapeople.org/rust-gstreamer-gl-wayland-sys-0.20.0-1.fc40.src.rpm
Description:
FFI bindings to libgstgl-1.0 (Wayland support).

Fedora Account System Username: kalev

Comment 1 Fabio Valentini 2023-09-28 20:32:18 UTC
Please address this:
# FIXME: no license files detected

Looks like an oversight by the upstream project, since almost all other gstreamer-rs crates we have packaged have license files.
Until it is addressed upstream (it's not in v0.21.0 either), please include the upstream MIT license text manually (as a second source file).

Comment 2 Kalev Lember 2023-09-28 20:54:17 UTC
Thanks! I went ahead and opened an upstream MR to add the missing license symlinks: https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/merge_requests/1315

Comment 3 Kalev Lember 2023-09-28 21:03:49 UTC
* Thu Sep 28 2023 Kalev Lember <klember> - 0.20.0-2
- Add missing license files from upstream

Spec URL: https://kalev.fedorapeople.org/rust-gstreamer-gl-wayland-sys.spec
SRPM URL: https://kalev.fedorapeople.org/rust-gstreamer-gl-wayland-sys-0.20.0-2.fc40.src.rpm

Comment 4 Fabio Valentini 2023-09-28 21:37:50 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files (included manually)
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 5 Kalev Lember 2023-09-28 21:39:27 UTC
Thanks a lot for all the reviews, Fabio!

Comment 6 Fedora Admin user for bugzilla script actions 2023-09-28 21:39:31 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gstreamer-gl-wayland-sys

Comment 7 Fedora Update System 2023-09-28 21:52:10 UTC
FEDORA-2023-aee7a4c88e has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-aee7a4c88e

Comment 8 Fedora Update System 2023-09-28 21:55:44 UTC
FEDORA-2023-aee7a4c88e has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.