Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2250689 - Review Request: python-untangle - Converts XML to Python objects
Summary: Review Request: python-untangle - Converts XML to Python objects
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Tom Rix
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1974565 2245786
TreeView+ depends on / blocked
 
Reported: 2023-11-20 15:04 UTC by Michal Ambroz
Modified: 2024-01-31 02:09 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-01-31 01:42:10 UTC
Type: ---
Embargoed:
trix: fedora-review+


Attachments (Terms of Use)

Description Michal Ambroz 2023-11-20 15:04:38 UTC
Spec URL: https://rebus.fedorapeople.org/python-untangle.spec
SRPM URL: https://rebus.fedorapeople.org/python-untangle-1.2.1-1.fc39.src.rpm

Description:
Converts XML to a Python object. Siblings with similar names are grouped into
a list. Children can be accessed with parent.child, attributes with
element['attribute'].

Fedora Account System Username: rebus

Comment 1 Michal Ambroz 2023-11-20 15:04:42 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=109302890

Comment 2 Michal Ambroz 2023-11-20 15:23:46 UTC
This package is needed for the #2245786 python-xlmmacrodeobfuscator, #1974565 new version 0.60.1 of oletools

Comment 3 Fedora Review Service 2023-11-20 16:27:26 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6670535
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250689-python-untangle/srpm-builds/06670535/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Tom Rix 2023-12-28 13:47:52 UTC
Need to change to newer python guidelines
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
Unless there is a good reason.
I think this is just using this bit

%build                                                                                                                            
%pyproject_wheel                                                                                                                  
                                                                                                                                  
%install                                                                                                                          
%pyproject_install                                                                                                                
                                                                                                                                  
%py3_shebang_fix %{buildroot}%{python3_sitelib}/untangle.py    

and in %files

%{python3_sitelib}/untangle-%{version}.dist-info  

--
URL:            https://github.com/stchris/untangle                                                                               
Source0:        https://github.com/stchris/untangle/archive/refs/tags/%{version}.tar.gz#/%{name}-%{version}.tar.gz 

Source0 can be simplified by use of %{url}

--

My local fedora-review shows this problem in the original 
python3-untangle.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/untangle.py 644 /usr/bin/env python  
which may be fixed by the shebang_fix line above.

Comment 5 Michal Ambroz 2024-01-02 03:21:38 UTC
I would love to use pyproject macros, but these are not available in epel7 at all and having problems in epel8 and I would like to keep maintaining just one spec.file if possible.
As it is it builds for all supported epel / fedora branches:
https://copr.fedorainfracloud.org/coprs/rebus/infosec/build/6760559/

Comment 6 Tom Rix 2024-01-02 13:32:55 UTC
(In reply to Michal Ambroz from comment #5)
> I would love to use pyproject macros, but these are not available in epel7
> at all and having problems in epel8 and I would like to keep maintaining
> just one spec.file if possible.
Sounds fine.  Please add this as a comment to the spec file and address the couple of other issues.

Comment 7 Michal Ambroz 2024-01-19 00:51:07 UTC
Spec URL: https://rebus.fedorapeople.org/python-untangle.spec
SRPM URL: https://rebus.fedorapeople.org/python-untangle-1.2.1-2.fc39.src.rpm

Hello Tom,
here is the update. I have removed the mentioned shebang and reported upstream.

Comment 8 Fedora Review Service 2024-01-19 00:56:01 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6916394
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250689-python-untangle/fedora-rawhide-x86_64/06916394-python-untangle/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 9 Tom Rix 2024-01-19 01:48:35 UTC
Looks fine.
Thanks for the changes
Approved.

Comment 10 Michal Ambroz 2024-01-19 08:58:29 UTC
Thank you

Comment 11 Fedora Admin user for bugzilla script actions 2024-01-21 18:57:05 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-untangle

Comment 12 Fedora Update System 2024-01-23 00:02:42 UTC
FEDORA-2024-1d5171cb15 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-1d5171cb15

Comment 13 Fedora Update System 2024-01-23 00:02:44 UTC
FEDORA-EPEL-2024-6d14702bbd has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-6d14702bbd

Comment 14 Fedora Update System 2024-01-23 00:03:11 UTC
FEDORA-2024-66ca9d4e05 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-66ca9d4e05

Comment 15 Fedora Update System 2024-01-23 00:03:16 UTC
FEDORA-EPEL-2024-3bb3562f47 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-3bb3562f47

Comment 16 Fedora Update System 2024-01-23 00:03:38 UTC
FEDORA-EPEL-2024-72f5662573 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-72f5662573

Comment 17 Fedora Update System 2024-01-23 01:18:27 UTC
FEDORA-2024-1d5171cb15 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-1d5171cb15 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-1d5171cb15

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Fedora Update System 2024-01-23 01:28:02 UTC
FEDORA-EPEL-2024-3bb3562f47 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-3bb3562f47

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 19 Fedora Update System 2024-01-23 01:29:26 UTC
FEDORA-EPEL-2024-72f5662573 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-72f5662573

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 20 Fedora Update System 2024-01-23 01:33:58 UTC
FEDORA-EPEL-2024-6d14702bbd has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-6d14702bbd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 21 Fedora Update System 2024-01-23 01:52:01 UTC
FEDORA-2024-66ca9d4e05 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-66ca9d4e05 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-66ca9d4e05

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 22 Fedora Update System 2024-01-31 01:42:10 UTC
FEDORA-2024-66ca9d4e05 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 23 Fedora Update System 2024-01-31 01:50:49 UTC
FEDORA-EPEL-2024-3bb3562f47 has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 24 Fedora Update System 2024-01-31 02:04:15 UTC
FEDORA-2024-1d5171cb15 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 25 Fedora Update System 2024-01-31 02:05:47 UTC
FEDORA-EPEL-2024-6d14702bbd has been pushed to the Fedora EPEL 7 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 26 Fedora Update System 2024-01-31 02:09:01 UTC
FEDORA-EPEL-2024-72f5662573 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.