Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2251104 - Review Request: elementary-code - Code editor from elementary
Summary: Review Request: elementary-code - Code editor from elementary
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/elementary/%{srcname}
Whiteboard:
Depends On:
Blocks: PantheonDesktopPackageReviews
TreeView+ depends on / blocked
 
Reported: 2023-11-22 22:18 UTC by Fabio Valentini
Modified: 2023-11-27 15:29 UTC (History)
2 users (show)

Fixed In Version: elementary-code-7.1.0-1.fc40
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-27 15:29:48 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Fabio Valentini 2023-11-22 22:18:00 UTC 
Spec URL: https://decathorpe.fedorapeople.org/elementary-code.spec
SRPM URL: https://decathorpe.fedorapeople.org/elementary-code-7.1.0-1.fc39.src.rpm

Description:
Code editor from elementary.

Fedora Account System Username: decathorpe
Comment 1 Fabio Valentini 2023-11-22 22:18:03 UTC 
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=109417912
Comment 2 Fedora Review Service 2023-11-22 22:37:24 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6681298
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251104-elementary-code/fedora-rawhide-x86_64/06681298-elementary-code/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 3 Neal Gompa 2023-11-26 01:52:51 UTC 
Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

Note, it looks like the "ro_MD" locale directories is un-owned and needs to be handled somewhere: /usr/share/locale/ro_MD/LC_MESSAGES, /usr/share/locale/ro_MD
This probably needs to be handled in "filesystem".

Additionally, /usr/share/polkit-1 and /usr/share/polkit-1/actions are owned by polkit and this should require that package. This adjustment can be made on import.

PACKAGE APPROVED.
Comment 4 Fabio Valentini 2023-11-26 17:18:13 UTC 
Thank you for the review!

I've filed a bug against the "filesystem" package:
https://bugzilla.redhat.com/show_bug.cgi?id=2251577

And will address the missing "Requires: polkit" before re-importing the package.
Comment 5 Fabio Valentini 2023-11-26 17:24:58 UTC 
https://pagure.io/releng/issue/11807
Comment 6 Fabio Valentini 2023-11-27 15:29:48 UTC 
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-b2284dc561
Note You need to log in before you can comment on or make changes to this bug.