Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2252086 - Review Request: rust-fast-srgb8 - Very fast conversions between linear float and 8-bit sRGB
Summary: Review Request: rust-fast-srgb8 - Very fast conversions between linear float ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ben Beasley
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/fast-srgb8
Whiteboard:
Depends On:
Blocks: 2107821
TreeView+ depends on / blocked
 
Reported: 2023-11-29 12:27 UTC by Fabio Valentini
Modified: 2023-12-08 22:20 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-12-08 22:20:11 UTC
Type: ---
Embargoed:
code: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-11-29 12:27:25 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-fast-srgb8.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-fast-srgb8-1.0.0-1.fc39.src.rpm

Description:
Very fast conversions between linear float and 8-bit sRGB (with no_std
support).

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-11-29 12:27:28 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=109696728

Comment 2 Fedora Review Service 2023-11-29 12:30:48 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6705180
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2252086-rust-fast-srgb8/fedora-rawhide-x86_64/06705180-rust-fast-srgb8/fedora-review/review.txt

Found issues:

- License file LICENSE-CC0 is not marked as %license
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Ben Beasley 2023-12-05 17:12:59 UTC
After discussion in the Fedora Rust matrix channel, I agree that it is OK that
SSE2 is enabled on i686, because since there is no i686 kernel in Fedora today,
i686 code must be running on x86_64 hardware, which means SSE2 support can be
assumed.

The package is APPROVED, but please consider removing LICENSE-CC0 in %prep.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


The spec file is exactly as emitted from rust2rpm except for the patch to
remove the CC0-1.0 license option, which simplifies the review.


Issues:
=======
- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /usr/share/cargo/registry/fast-
  srgb8-1.0.0/LICENSE-APACHE
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_duplicate_files

  This is due to rust2rpm listing the entire %{crate_instdir}/ and then
  separately listing some of its contents as %doc/%license. The duplication
  appears to be harmless; if it is a problem, then it should be fixed in
  rust2rpm.

- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE-CC0 is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text

  The way the inapplicable (not-allowed for code in Fedora) CC0-1.0 license is
  patched out of the crate metadata makes sense. Consider also removing the
  inapplicable LICENSE-CC0 license file in %prep (“rm LICENSE-CC0”) after
  %autosetup.


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Apache License 2.0",
     "*No copyright* Creative Commons CC0 1.0", "MIT License". 7 files have
     unknown license. Detailed output of licensecheck in
     /home/ben/Downloads/review/2252086-rust-fast-srgb8/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
     fast-srgb8-devel , rust-fast-srgb8+default-devel
[x]: Package functions as described.

     (tests pass)

[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rust-fast-srgb8-devel-1.0.0-1.fc40.noarch.rpm
          rust-fast-srgb8+default-devel-1.0.0-1.fc40.noarch.rpm
          rust-fast-srgb8-1.0.0-1.fc40.src.rpm
===================================================================== rpmlint session starts =====================================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpq8tfs1cy')]
checks: 31, packages: 3

rust-fast-srgb8+default-devel.noarch: W: no-documentation
====================================== 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s ======================================




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2

rust-fast-srgb8+default-devel.noarch: W: no-documentation
 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 8 filtered, 0 badness; has taken 0.0 s 



Source checksums
----------------
https://crates.io/api/v1/crates/fast-srgb8/1.0.0/download#/fast-srgb8-1.0.0.crate :
  CHECKSUM(SHA256) this package     : dd2e7510819d6fbf51a5545c8f922716ecfb14df168a3242f7d33e0239efe6a1
  CHECKSUM(SHA256) upstream package : dd2e7510819d6fbf51a5545c8f922716ecfb14df168a3242f7d33e0239efe6a1


Requires
--------
rust-fast-srgb8-devel (rpmlib, GLIBC filtered):
    cargo

rust-fast-srgb8+default-devel (rpmlib, GLIBC filtered):
    cargo
    crate(fast-srgb8)



Provides
--------
rust-fast-srgb8-devel:
    crate(fast-srgb8)
    rust-fast-srgb8-devel

rust-fast-srgb8+default-devel:
    crate(fast-srgb8/default)
    rust-fast-srgb8+default-devel



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2252086
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Ocaml, PHP, Haskell, SugarActivity, fonts, Python, R, Java, Perl, C/C++
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comment 4 Fedora Admin user for bugzilla script actions 2023-12-08 16:50:23 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-fast-srgb8

Comment 5 Fedora Update System 2023-12-08 22:16:26 UTC
FEDORA-2023-949914e847 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-949914e847

Comment 6 Fedora Update System 2023-12-08 22:20:11 UTC
FEDORA-2023-949914e847 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.