Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2254614 - Review Request: wingpanel - Stylish top panel
Summary: Review Request: wingpanel - Stylish top panel
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/elementary/wingpanel
Whiteboard:
Depends On:
Blocks: PantheonDesktopPackageReviews
TreeView+ depends on / blocked
 
Reported: 2023-12-14 21:23 UTC by Fabio Valentini
Modified: 2023-12-21 20:09 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-12-21 20:09:45 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-12-14 21:23:44 UTC
Spec URL: https://decathorpe.fedorapeople.org/wingpanel.spec
SRPM URL: https://decathorpe.fedorapeople.org/wingpanel-3.0.5-3.20231206.git0fb4a14.fc39.src.rpm

Description:
Stylish top panel that holds indicators and spawns an application
launcher.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-12-14 21:23:47 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=110345663

Comment 2 Fedora Review Service 2023-12-14 21:35:00 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6758062
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254614-wingpanel/fedora-rawhide-x86_64/06758062-wingpanel/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/wingpanel
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Neal Gompa 2023-12-15 00:14:02 UTC
 Review notes:

* Package (mostly) follows Fedora Packaging Guidelines
  + Please add "BuildRequires: gcc" on import
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 4 Fabio Valentini 2023-12-18 13:54:05 UTC
Thank you for the review!
I'll add BR: gcc before unretiring the package.

Comment 5 Fabio Valentini 2023-12-18 13:59:11 UTC
https://pagure.io/releng/issue/11841

Comment 6 Fabio Valentini 2023-12-21 20:09:45 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-f2c18bc99f


Note You need to log in before you can comment on or make changes to this bug.