Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2254615 - Review Request: elementary-files - File manager from elementary
Summary: Review Request: elementary-files - File manager from elementary
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/elementary/%{srcname}
Whiteboard:
Depends On:
Blocks: PantheonDesktopPackageReviews
TreeView+ depends on / blocked
 
Reported: 2023-12-14 21:39 UTC by Fabio Valentini
Modified: 2023-12-21 20:10 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-12-21 20:10:13 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Fabio Valentini 2023-12-14 21:39:33 UTC 
Spec URL: https://decathorpe.fedorapeople.org/elementary-files.spec
SRPM URL: https://decathorpe.fedorapeople.org/elementary-files-6.5.3-1.fc39.src.rpm

Description:
The simple, powerful, and sexy file manager from elementary.

Fedora Account System Username: decathorpe
Comment 1 Fabio Valentini 2023-12-14 21:39:36 UTC 
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=110346580
Comment 2 Fedora Review Service 2023-12-14 21:55:33 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6758086
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254615-elementary-files/fedora-rawhide-x86_64/06758086-elementary-files/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/elementary-files
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names
- Systemd user unit service file(s) in elementary-files-portal
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 3 Neal Gompa 2023-12-15 00:16:21 UTC 
 Review notes:

* Package (mostly) follows Fedora Packaging Guidelines
  + Please add "BuildRequires: gcc" on import
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

Other notes: Is there a preferred polkit agent? If so, maybe a "Suggests" for that should be added... This can be done on import if you wish.

PACKAGE APPROVED.
Comment 4 Fabio Valentini 2023-12-18 13:54:59 UTC 
Thanks for the review!

I'll add BR: gcc before unretiring the package.

Preferred polkit agent is likely https://github.com/elementary/pantheon-agent-polkit
I'll add Suggests for it as soon as it's back in Fedora.
Comment 5 Fabio Valentini 2023-12-18 14:02:13 UTC 
https://pagure.io/releng/issue/11842
Comment 6 Fabio Valentini 2023-12-21 20:10:13 UTC 
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-4e570c70cc
Note You need to log in before you can comment on or make changes to this bug.