Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2254617 - Review Request: elementary-music - Music player and library designed for elementary
Summary: Review Request: elementary-music - Music player and library designed for elem...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/elementary/%{srcname}
Whiteboard:
Depends On:
Blocks: PantheonDesktopPackageReviews
TreeView+ depends on / blocked
 
Reported: 2023-12-14 22:00 UTC by Fabio Valentini
Modified: 2023-12-21 20:09 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-12-21 20:09:22 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Fabio Valentini 2023-12-14 22:00:58 UTC 
Spec URL: https://decathorpe.fedorapeople.org/elementary-music.spec
SRPM URL: https://decathorpe.fedorapeople.org/elementary-music-7.1.0-1.fc39.src.rpm

Description:
Quickly queue up and listen to your local music files without any extra
frills. See embedded album artwork. Control playback with media keys or
in the system audio indicator.

Fedora Account System Username: decathorpe
Comment 1 Fabio Valentini 2023-12-14 22:01:00 UTC 
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=110347453
Comment 2 Fedora Review Service 2023-12-14 22:10:30 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6758117
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254617-elementary-music/fedora-rawhide-x86_64/06758117-elementary-music/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/elementary-music
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 3 Neal Gompa 2023-12-15 00:18:19 UTC 
Review notes:

* Package (mostly) follows Fedora Packaging Guidelines
  + Please add "BuildRequires: gcc" on import, just to ensure the right C compiler is used.
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

PACKAGE APPROVED.
Comment 4 Fabio Valentini 2023-12-18 13:57:43 UTC 
Thank you for the review!
I'll add BR: gcc before re-importing the package.
Comment 5 Fabio Valentini 2023-12-18 14:05:30 UTC 
https://pagure.io/releng/issue/11844
Comment 6 Fabio Valentini 2023-12-21 20:09:22 UTC 
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-c4479b7d26
Note You need to log in before you can comment on or make changes to this bug.