Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 228468 - Review Request: hunspell-da - Danish hunspell dictionaries
Summary: Review Request: hunspell-da - Danish hunspell dictionaries
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: manuel wolfshant
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2007-02-13 09:21 UTC by Caolan McNamara
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-02-14 09:48:15 UTC
Type: ---
Embargoed:
wolfy: fedora-review+
notting: fedora-cvs+

Attachments (Terms of Use)

Description Caolan McNamara 2007-02-13 09:21:32 UTC 
Spec URL: http://people.redhat.com/caolanm/hunspell/hunspell-da.spec
SRPM URL: http://people.redhat.com/caolanm/hunspell/hunspell-da-0.20050330-1.src.rpm
Description: Danish hunspell dictionaries


Similar to 227811
Comment 1 manuel wolfshant 2007-02-13 10:02:27 UTC 
This package does not include the most recent upstream version of the files and
therefore the sha1sum of the included zip is not the same with the one from
%Source0.

Please update to the current version (06-Jan-2007) or explain why should the
previous version be accepted (and how can it be verified) before continuing the
review.
Comment 2 Caolan McNamara 2007-02-13 10:44:13 UTC 
Indeed, new danish dictionaries available. 

Updated as
http://people.redhat.com/caolanm/hunspell/hunspell-da-0.20070106-1.src.rpm
http://people.redhat.com/caolanm/hunspell/hunspell-da.spec
Comment 3 manuel wolfshant 2007-02-13 11:36:17 UTC 
- package meets naming guidelines
- package meets packaging guidelines 
- spec file legible, in am. english
- source matches upstream , sha1sum 
75bc7fbcbb9736cc4615bf19a5d74001e8c468ac  da_DK.zip
- the package builds in mock for devel/x86_64, generates a noarch (which is
consistent with the fact that basically it includes only 3 text files)
- the license GPL stated in the tag is the same as the one included in the
upstream archive
- there are only 2 files (word lists) + a short doc with instructions and
license clearance, so no need for -doc and no .la, .pc, static files
- no missing BR
- no locales
- not relocatable
- owns all files/directories that it creates, does not take ownership of other
files/dirs
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- rpmlint outputsilent
- code, not content
- no need for -docs as the only doc is just the GPL license + usage instructions
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED
Comment 4 Caolan McNamara 2007-02-14 09:48:15 UTC 
 27540 (hunspell-da): Build on target fedora-development-extras succeeded.
Note You need to log in before you can comment on or make changes to this bug.