Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 487052 - Review Request: dc3dd - Patched version of GNU dd for use in computer forensics
Summary: Review Request: dc3dd - Patched version of GNU dd for use in computer forensics
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Orcan Ogetbil
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-02-23 20:53 UTC by Adam Miller
Modified: 2014-10-17 17:39 UTC (History)
5 users (show)

Fixed In Version: dc3dd-7.1.614-8.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-03-09 22:43:28 UTC
Type: ---
Embargoed:
oget.fedora: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Adam Miller 2009-02-23 20:53:39 UTC
Spec URL: http://maxamillion.fedorapeople.org/dc3dd.spec
SRPM URL: http://maxamillion.fedorapeople.org/dc3dd-6.12.2-1.src.rpm
Description: 

dc3dd is a patched version of GNU dd to include a number of features useful
for computer forensics. Many of these features were inspired by dcfldd, but
were rewritten for dc3dd.

    * Pattern writes. The program can write a single hexadecimal value or a
    text string to the output device for wiping purposes.
    * Piecewise and overall hashing with multiple algorithms and variable 
    size windows. Supports MD5, SHA-1, SHA-256, and SHA-512. Hashes can be 
    computed before or after conversions are made.
    * Progress meter with automatic input/output file size probing
    * Combined log for hashes and errors
    * Error grouping. Produces one error message for identical sequential 
    errors
    * Verify mode. Able to repeat any transformations done to the input 
    file and compare it to an output.
    * Ability to split the output into chunks with numerical or alphabetic 
    extensions

Comment 1 Orcan Ogetbil 2009-03-01 07:23:09 UTC
I had a look at this package. Here are my notes:

! Not a blocker but a suggestion: The recommended buildroot values are given in
   http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

* Source0 is wrong.

* rpmlint says:
   dc3dd.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/dc3dd-6.12.2/README
You can probably correct this with
   sed 's|\r||' README > README.tmp
   touch -r README README.tmp
   mv -f README.tmp README
in %prep.

* Please remove the binary .gmo files in %prep.

* It looks like the files NEWS, Options_Reference.txt, Sample_Commands.txt should go to %doc.

* Each package must consistently use macros. Please make use of the %{name} macro.

* Parallel make must be supported whenever possible. If it is not supported, this should be noted in the SPEC file as a comment.

* The file lib/getdate.c is GPLv2+. That makes the license GPLv2+ and GPLv3+.

? What is the directory build-aux and the executable files in the root of the source tree for?

Comment 2 Adam Miller 2009-03-03 14:48:19 UTC
Spec URL: http://maxamillion.fedorapeople.org/dc3dd.spec
SRPM URL: http://maxamillion.fedorapeople.org/dc3dd-6.12.2-2.src.rpm

I've cleaned up everything listed above. I fixed the licensing, removed the .gmo binaries, fixed source0 (sorry for that one, I based this spec off another spec of mine and mixed that up), added the doc items you listed, and fixed EOF encoding for the current and two added files to the package.

Thank you very much for your feedback and I look forward to further review.

Comment 3 Orcan Ogetbil 2009-03-04 02:31:22 UTC
Thanks for the update.

* To clean up the SPEC file you can use a for-loop like: 

for file in README Sample_Commands.txt Options_Reference.txt; do
   sed 's|\r||' $file > $file.tmp
   touch -r $file $file.tmp
   mv -f $file.tmp $file
done

* You probably missed this question I asked:

> ? What is the directory build-aux and the executable files in the root of the
source tree for?

The reason I asked was: If these files run tests to check whether the application is compiled properly, you will need to make a %check section and run these tests.
On the other hand, if these scripts are useful for people who want to use/develop dc3dd, you might want to put them in %{_datadir}/%{name} or inside %doc.

Comment 4 Adam Miller 2009-03-05 17:20:40 UTC
Spec URL: http://maxamillion.fedorapeople.org/dc3dd.spec
SRPM URL: http://maxamillion.fedorapeople.org/dc3dd-6.12.2-3.src.rpm

I applied the cleanup and I inspected the source of a number of the files in the build-aux directory and they appear to just be a cludge of python scripts that provide work arounds for different build environments and/or compilers that don't support certain things.

Thank you again for your comments, looking forward to further review.

Comment 5 Orcan Ogetbil 2009-03-05 18:17:07 UTC
So, those files are irrelevant. Then I think everything is fine now. You're welcome

----------------------------------------
This package (dc3dd) is APPROVED by oget
----------------------------------------

Comment 6 Adam Miller 2009-03-05 18:40:11 UTC
New Package CVS Request
=======================
Package Name: dc3dd
Short Description: Patched version of GNU dd for use in computer forensics
Owners: maxamillion
Branches: F-9 F-10 EL-4 EL-5
InitialCC:

Comment 7 Kevin Fenzi 2009-03-05 20:24:18 UTC
cvs done.

Comment 8 Fedora Update System 2009-03-06 15:21:37 UTC
dc3dd-6.12.2-3.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/dc3dd-6.12.2-3.fc9

Comment 9 Fedora Update System 2009-03-06 15:21:42 UTC
dc3dd-6.12.2-3.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/dc3dd-6.12.2-3.fc10

Comment 10 Fedora Update System 2009-03-09 22:43:23 UTC
dc3dd-6.12.2-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2009-03-09 22:57:10 UTC
dc3dd-6.12.2-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Michal Ambroz 2014-09-23 18:40:38 UTC
Package Change Request
======================
Package Name: dc3dd
New Branches: epel7
Owners: maxamillion rebus

Hello SCM team,
plase can you add epel7 branch for the dc3dd package?
Thank you
Michal Ambroz

Comment 13 Gwyn Ciesla 2014-09-23 19:13:59 UTC
Git done (by process-git-requests).

Comment 14 Fedora Update System 2014-09-24 08:12:06 UTC
dc3dd-7.1.614-8.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/dc3dd-7.1.614-8.el7

Comment 15 Fedora Update System 2014-10-17 17:39:33 UTC
dc3dd-7.1.614-8.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.