Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 510808 - Review Request: pondus - A personal weight management program
Summary: Review Request: pondus - A personal weight management program
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-07-10 21:10 UTC by Susi Lehtola
Modified: 2009-08-08 19:26 UTC (History)
2 users (show)

Fixed In Version: 0.5.3-2.fc10
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-07-29 22:58:15 UTC
Type: ---
Embargoed:
j: fedora-review+
j: fedora-cvs+

Attachments (Terms of Use)

Description Susi Lehtola 2009-07-10 21:10:49 UTC 
Spec URL:
http://theory.physics.helsinki.fi/~jzlehtol/rpms/pondus.spec

SRPM URL:
http://theory.physics.helsinki.fi/~jzlehtol/rpms/pondus-0.5.3-1.fc11.src.rpm

Upstream URL: http://www.ephys.de/software/pondus/

Description:
Pondus is a personal weight management program written in Python and Gtk+2
released under the GPL. It aims to be simple to use, lightweight and fast.
The data can be plotted to get a quick overview of the history of your weight.
A simple weight planner allows to define "target weights" and this plan can be
compared with the actual measurements in a plot.

rpmlint output is clean.
Comment 1 Jason Tibbitts 2009-07-11 06:44:42 UTC 
Did you consider a dependency on python-matplotlib?  Without it you can't actually plot anything, and the description probably needs to account for that.  Also, the message printed when you don't have python-matplotlib doesn't really help the user to figure out what package to install.  (It references "Matplotlib", which you can search for, but it would be better if it indicated the package name.)

I don't think that's a blocker, but do think of the users.

* source files match upstream.  sha256sum:           
   5b5dcecd570d2242663771f23d5d7679164fb04a82accf6a142b78bf485c1181
   pondus-0.5.3.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.                                                              
* description is OK.                                                          
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   pondus = 0.5.3-1.fc12
  =
   /usr/bin/python
   python(abi) = 2.6

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* desktop files valid and installed properly.

APPROVED
Comment 2 Susi Lehtola 2009-07-11 09:14:14 UTC 
Thanks for the review, and for spotting the missing req!

New Package CVS Request
=======================
Package Name: pondus
Short Description: A personal weight management program
Owners: jussilehtola
Branches: F-10 F-11
InitialCC:
Comment 3 Susi Lehtola 2009-07-11 09:15:21 UTC 
Actually, I think I want the EPEL 5 branch as well.

New Package CVS Request
=======================
Package Name: pondus
Short Description: A personal weight management program
Owners: jussilehtola
Branches: EL-5 F-10 F-11
InitialCC:
Comment 4 Jason Tibbitts 2009-07-11 14:17:51 UTC 
CVS done.
Comment 5 Fedora Update System 2009-07-11 19:04:41 UTC 
pondus-0.5.3-3.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/pondus-0.5.3-3.el5
Comment 6 Fedora Update System 2009-07-11 19:05:44 UTC 
pondus-0.5.3-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/pondus-0.5.3-2.fc10
Comment 7 Fedora Update System 2009-07-11 19:06:32 UTC 
pondus-0.5.3-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/pondus-0.5.3-2.fc11
Comment 8 Fedora Update System 2009-07-13 19:39:05 UTC 
pondus-0.5.3-3.el5 has been pushed to the Fedora EPEL 5 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update pondus'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0067
Comment 9 Fedora Update System 2009-07-16 06:55:40 UTC 
pondus-0.5.3-2.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update pondus'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-7564
Comment 10 Fedora Update System 2009-07-16 07:32:48 UTC 
pondus-0.5.3-2.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update pondus'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-7681
Comment 11 Fedora Update System 2009-07-29 22:58:11 UTC 
pondus-0.5.3-3.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 12 Fedora Update System 2009-08-08 19:21:56 UTC 
pondus-0.5.3-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 13 Fedora Update System 2009-08-08 19:26:29 UTC 
pondus-0.5.3-2.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.