Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 516517 - Review Request: globus-gridftp-server - Globus Toolkit - Globus GridFTP Server
Summary: Review Request: globus-gridftp-server - Globus Toolkit - Globus GridFTP Server
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Steve Traylen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 516514 516515 516516
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-08-10 11:01 UTC by Mattias Ellert
Modified: 2009-12-01 18:25 UTC (History)
3 users (show)

Fixed In Version: 3.17-2.el4
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-11-10 17:48:26 UTC
Type: ---
Embargoed:
steve.traylen: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Mattias Ellert 2009-08-10 11:01:41 UTC
Spec URL: http://www.grid.tsl.uu.se/review/globus-gridftp-server.spec
SRPM URL: http://www.grid.tsl.uu.se/review/globus-gridftp-server-3.17-1.fc11.src.rpm

Description:
The Globus Toolkit is an open source software toolkit used for building Grid
systems and applications. It is being developed by the Globus Alliance and
many others all over the world. A growing number of projects and companies are
using the Globus Toolkit to unlock the potential of grids for their cause.

The globus-gridftp-server package contains:
Globus GridFTP Server

Globus Toolkit Packaging Guidelines:
https://fedoraproject.org/wiki/Packaging:Globus

Comment 1 Steve Traylen 2009-11-03 23:24:14 UTC
Review of globus-gridftp-server

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1786926

almost: rpmlint
$ rpmlint SPECS/globus-gridftp-server.spec \
    RPMS/x86_64/globus-gridftp-server-* \
    SRPMS/globus-gridftp-server-3.17-1.fc12.src.rpm 

globus-gridftp-server.x86_64: W: shared-lib-calls-exit /usr/lib64/libglobus_gridftp_server.so.0.3.17 exit.5
globus-gridftp-server.x86_64: W: no-documentation
globus-gridftp-server-devel.x86_64: W: no-documentation
globus-gridftp-server-progs.x86_64: W: no-documentation
5 packages and 1 specfiles checked; 0 errors, 4 warnings.

yes: package named as per-globus.
yes: spec file correct.
yes: globus guidelines good.
yes: ASL 2.0 in .spec
yes: contents is also ASL 2.0
yes: GLOBUS_LICEENSE include.
yes: english .spec
yes: legible spec.
yes: upstream matches.

$ md5sum globus_gridftp_server-3.17.tar.gz ~/rpmbuild/SOURCES/globus_gridftp_server-3.17.tar.gz 
4f1b25af2672acd1f9eaee3e6a6be40e  globus_gridftp_server-3.17.tar.gz
4f1b25af2672acd1f9eaee3e6a6be40e  /home/steve/rpmbuild/SOURCES/globus_gridftp_server-3.17.tar.gz


yes: compiles , see koji above.
yes: builds on all archs.
yes: builds on all archs.
yes: build dependencies sane.
yes: no locales anyway.
yes: ldoconfig called correctly.
yes: no statics.
yes: owns all directories.
yes: no duplicate files.
yes: all %defattr.
yes: %clean is cleaned.
yes: contains code.
yes: no large docs anyway.
yes: doc not needed.
yes: headers are in devel.
yes: pkgconfig required.
yes: devel does require base explicitly.
yes: no gui.
yes: owns all files or directories or pulls them in.
yes: %install is cleaned.
yes: utf8.

At last a package that actually does something useful :-)

Can you submit a bug upstream on 0 exit from lib and I'll approve.

Steve

Comment 2 Mattias Ellert 2009-11-05 04:56:11 UTC
Reported upstream:

http://bugzilla.globus.org/globus/show_bug.cgi?id=6881

Mattias

Comment 3 Steve Traylen 2009-11-05 07:58:10 UTC
APPROVED.

Comment 4 Mattias Ellert 2009-11-05 08:16:13 UTC
Thank you for the review!

New Package CVS Request
=======================
Package Name: globus-gridftp-server
Short Description: Globus Toolkit - Globus GridFTP Server
Owners: ellert
Branches: F-11 F-12 EL-4 EL-5
InitialCC:

Comment 5 Kevin Fenzi 2009-11-06 20:32:46 UTC
cvs done

Comment 6 Fedora Update System 2009-11-07 08:18:08 UTC
globus-gridftp-server-3.17-2.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/globus-gridftp-server-3.17-2.fc12

Comment 7 Fedora Update System 2009-11-07 08:18:14 UTC
globus-gridftp-server-3.17-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/globus-gridftp-server-3.17-2.fc11

Comment 8 Fedora Update System 2009-11-10 17:48:21 UTC
globus-gridftp-server-3.17-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2009-11-10 17:58:28 UTC
globus-gridftp-server-3.17-2.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2009-11-11 22:19:42 UTC
globus-gridftp-server-3.17-2.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/globus-gridftp-server-3.17-2.el5

Comment 11 Fedora Update System 2009-11-11 22:19:48 UTC
globus-gridftp-server-3.17-2.el4 has been submitted as an update for Fedora EPEL 4.
http://admin.fedoraproject.org/updates/globus-gridftp-server-3.17-2.el4

Comment 12 Fedora Update System 2009-12-01 18:24:59 UTC
globus-gridftp-server-3.17-2.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2009-12-01 18:25:29 UTC
globus-gridftp-server-3.17-2.el4 has been pushed to the Fedora EPEL 4 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.