Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 561086 - Review Request: perl-String-Escape - String::Escape Perl module
Summary: Review Request: perl-String-Escape - String::Escape Perl module
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Chris Weyl
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-02-02 16:44 UTC by Xavier Bachelot
Modified: 2010-03-13 02:32 UTC (History)
3 users (show)

Fixed In Version: perl-String-Escape-2010.002-3.fc13
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-12 03:40:13 UTC
Type: ---
Embargoed:
cweyl: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Xavier Bachelot 2010-02-02 16:44:56 UTC
Spec URL: http://www.bachelot.org/fedora/SPECS/perl-String-Escape.spec
SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-String-Escape-2010.002-1.fc12.src.rpm
Description: 
This module provides a flexible calling interface to some frequently-
performed string conversion functions, including applying and expanding
standard C/Unix-style backslash escapes like \n and \t, wrapping and
removing double-quotes, and truncating to fit within a desired length.

Comment 1 Chris Weyl 2010-02-07 00:37:22 UTC
And here: 

Requires:       perl(Test::More)

is suspect as well...

Comment 2 Xavier Bachelot 2010-02-07 22:02:24 UTC
Same reasoning as the other one, I'll remove it. Anything else ?

Comment 3 Chris Weyl 2010-02-08 07:12:19 UTC
Not at the moment.  Put up a new spec/srpm and I'll review :)

Comment 4 Xavier Bachelot 2010-02-08 09:43:31 UTC
New version :
- Remove unwanted Requires: perl(Test::More).

Spec URL: http://www.bachelot.org/fedora/SPECS/perl-String-Escape.spec
SRPM URL:
http://www.bachelot.org/fedora/SRPMS/perl-String-Escape-2010.002-2.fc12.src.rpm

Comment 5 Chris Weyl 2010-02-13 19:17:03 UTC
Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=1983996

Comment 6 Chris Weyl 2010-02-13 19:44:51 UTC
Hmmm...  I'm seeing a 404 error when trying to fetch the upstream tarball.

[cweyl@athena bin]$ wget http://www.cpan.org/modules/by-module/String/String-Escape-2010.002.tar.gz
--2010-02-13 11:41:37--  http://www.cpan.org/modules/by-module/String/String-Escape-2010.002.tar.gz
Resolving www.cpan.org... 207.171.7.177
Connecting to www.cpan.org|207.171.7.177|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2010-02-13 11:41:37 ERROR 404: Not Found.

Comment 7 Xavier Bachelot 2010-02-14 10:56:55 UTC
Hohum, the tarball is not at the canonical location...

Fixed in :
Spec URL: http://www.bachelot.org/fedora/SPECS/perl-String-Escape.spec
SRPM URL:
http://www.bachelot.org/fedora/SRPMS/perl-String-Escape-2010.002-3.fc12.src.rpm

Comment 8 Chris Weyl 2010-02-20 06:09:30 UTC
Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=2001007

Comment 9 Chris Weyl 2010-02-20 06:12:59 UTC
Looks good, with a couple recommendations:

Given the recent issues with ExtUtils::MakeMaker and PERL_INSTALL_ROOT, you
will probably want to replace PERL_INSTALL_ROOT with DESTDIR under %install.

Please consider adding "%{?perl_default_filter}" to your spec, before the
%description block; even if the addition is merely pro-forma for this package.
It won't hurt anything and may well save some pain in the future.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2001007

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
d90f5d2f7146905ce314fe8b295848c8ac3b934c String-Escape-2010.002.tar.gz
d90f5d2f7146905ce314fe8b295848c8ac3b934c String-Escape-2010.002.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-String-Escape-2010.002-3.fc13.noarch.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-String-Escape-2010.002-3.fc13.noarch.rpm
perl(String::Escape) = 2010.002
perl-String-Escape = 2010.002-3.fc13
====> requires for perl-String-Escape-2010.002-3.fc13.noarch.rpm
perl(Carp)  
perl(Exporter)  
perl(:MODULE_COMPAT_5.10.1)  
perl(strict)  
perl(vars)  
perl(warnings)  

=====> perl-String-Escape-2010.002-3.fc13.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-String-Escape-2010.002-3.fc13.src.rpm
====> requires for perl-String-Escape-2010.002-3.fc13.src.rpm
perl(ExtUtils::MakeMaker)  
perl(Test::More)  
perl(Test::Pod)  
perl(Test::Pod::Coverage)  

APPROVED

Comment 10 Xavier Bachelot 2010-02-20 10:14:12 UTC
Thanks for the review Chris

New Package CVS Request
=======================
Package Name: perl-String-Escape
Short Description: String::Escape Perl module
Owners: xavierb
Branches: F-11 F-12 F-13 EL-5
InitialCC: perl-sig

Comment 11 Jason Tibbitts 2010-02-20 18:02:12 UTC
CVS done (by process-cvs-requests.py).

Comment 12 Fedora Update System 2010-02-22 00:04:53 UTC
perl-String-Escape-2010.002-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/perl-String-Escape-2010.002-3.fc12

Comment 13 Fedora Update System 2010-02-22 00:04:59 UTC
perl-String-Escape-2010.002-3.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/perl-String-Escape-2010.002-3.el5

Comment 14 Fedora Update System 2010-02-22 00:05:04 UTC
perl-String-Escape-2010.002-3.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/perl-String-Escape-2010.002-3.fc13

Comment 15 Fedora Update System 2010-02-22 00:05:08 UTC
perl-String-Escape-2010.002-3.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/perl-String-Escape-2010.002-3.fc11

Comment 16 Fedora Update System 2010-02-22 00:06:18 UTC
perl-String-Escape-2010.002-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/perl-String-Escape-2010.002-3.fc12

Comment 17 Fedora Update System 2010-02-22 00:06:44 UTC
perl-String-Escape-2010.002-3.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/perl-String-Escape-2010.002-3.el5

Comment 18 Fedora Update System 2010-02-22 00:07:09 UTC
perl-String-Escape-2010.002-3.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/perl-String-Escape-2010.002-3.fc13

Comment 19 Fedora Update System 2010-02-22 00:07:34 UTC
perl-String-Escape-2010.002-3.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/perl-String-Escape-2010.002-3.fc11

Comment 20 Fedora Update System 2010-02-22 22:39:31 UTC
perl-String-Escape-2010.002-3.el5 has been pushed to the Fedora EPEL 5 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-String-Escape'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2010-2292

Comment 21 Fedora Update System 2010-02-23 05:14:20 UTC
perl-String-Escape-2010.002-3.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-String-Escape'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-2469

Comment 22 Fedora Update System 2010-02-23 05:33:20 UTC
perl-String-Escape-2010.002-3.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-String-Escape'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F13/FEDORA-2010-2597

Comment 23 Fedora Update System 2010-02-23 05:34:03 UTC
perl-String-Escape-2010.002-3.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-String-Escape'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-2603

Comment 24 Fedora Update System 2010-03-12 03:40:08 UTC
perl-String-Escape-2010.002-3.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 25 Fedora Update System 2010-03-13 02:27:18 UTC
perl-String-Escape-2010.002-3.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 26 Fedora Update System 2010-03-13 02:27:34 UTC
perl-String-Escape-2010.002-3.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 27 Fedora Update System 2010-03-13 02:32:31 UTC
perl-String-Escape-2010.002-3.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.