Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 561761 - Review Request: perl-HTML-Entities-Numbered - Conversion of numbered HTML entities
Summary: Review Request: perl-HTML-Entities-Numbered - Conversion of numbered HTML ent...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Chris Weyl
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-02-04 08:41 UTC by Xavier Bachelot
Modified: 2010-03-16 19:35 UTC (History)
3 users (show)

Fixed In Version: perl-HTML-Entities-Numbered-0.04-2.el5
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-11 07:20:23 UTC
Type: ---
Embargoed:
cweyl: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Xavier Bachelot 2010-02-04 08:41:49 UTC 
Spec URL: http://www.bachelot.org/fedora/SPECS/perl-HTML-Entities-Numbered.spec
SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-HTML-Entities-Numbered-0.04-1.fc12.src.rpm
Description:
HTML::Entities::Numbered is a content conversion filter for named HTML
entities (symbols, mathmetical symbols, Greek letters, Latin letters,
etc.). When an argument of name2decimal() or name2hex() contains some
nameable HTML entities, they will be replaced to numbered HTML entities.
And when an argument of name2decimal_xml() or name2hex_xml() contains
some nameable numbered HTML entities, they will be replaced to numbered
HTML entities except valid XML entities (the excepted "valid XML
entities" are the following five entities: <, >, &, ",
'). By the same token, when an argument of decimal2name() or
hex2name() contains some nameable numbered HTML entities, they will be
replaced to named HTML entities.
Comment 1 Chris Weyl 2010-02-07 00:34:18 UTC 
This requires:

Requires:       perl(Test::More) >= 0.32

...seems suspect to me :)
Comment 2 Xavier Bachelot 2010-02-07 22:01:29 UTC 
Indeed, I'll remove it. I should now better to not trust cpanspec for this. Anything else beside of that ?
Comment 3 Xavier Bachelot 2010-02-08 09:42:47 UTC 
New version :
- Remove unwanted Requires: perl(Test::More).

Spec URL: http://www.bachelot.org/fedora/SPECS/perl-HTML-Entities-Numbered.spec
SRPM URL:
http://www.bachelot.org/fedora/SRPMS/perl-HTML-Entities-Numbered-0.04-2.fc12.src.rpm
Comment 4 Chris Weyl 2010-02-13 19:57:15 UTC 
Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=1984104
Comment 5 Chris Weyl 2010-02-13 20:07:16 UTC 
Not blockers, but:

Replacing PERL_INSTALL_ROOT with DESTDIR would seem to be a good idea, given
the recent fun along those lines :)

Think about including %{?perl_default_filter} by default, even if just pro
forma.  It won't hurt anything and might save some pain down the line.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1984104

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
894094d26046006d7afd332ad3860d761ed16405 HTML-Entities-Numbered-0.04.tar.gz
894094d26046006d7afd332ad3860d761ed16405 HTML-Entities-Numbered-0.04.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-HTML-Entities-Numbered-0.04-2.fc13.noarch.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-HTML-Entities-Numbered-0.04-2.fc13.noarch.rpm
perl(HTML::Entities::Numbered) = 0.04
perl-HTML-Entities-Numbered = 0.04-2.fc13
perl(HTML::Entities::Numbered::Table) = 0.01
====> requires for perl-HTML-Entities-Numbered-0.04-2.fc13.noarch.rpm
perl(base)  
perl(HTML::Entities::Numbered::Table)  
perl(:MODULE_COMPAT_5.10.1)  
perl(strict)  
perl(vars)  

=====> perl-HTML-Entities-Numbered-0.04-2.fc13.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-HTML-Entities-Numbered-0.04-2.fc13.src.rpm
====> requires for perl-HTML-Entities-Numbered-0.04-2.fc13.src.rpm
perl(ExtUtils::MakeMaker)  
perl(Test::More) >= 0.32

APPROVED
Comment 6 Xavier Bachelot 2010-02-14 10:59:25 UTC 
Thanks for the review Chris.

New Package CVS Request
=======================
Package Name: perl-HTML-Entities-Numbered
Short Description: Conversion of numbered HTML entities
Owners: xavierb
Branches: F-11 F-12 EL-5
InitialCC: perl-sig
Comment 7 Kevin Fenzi 2010-02-16 03:51:01 UTC 
CVS done (by process-cvs-requests.py).
Comment 8 Xavier Bachelot 2010-02-16 20:42:50 UTC 
Imported and building in all requested branches.

(In reply to comment #5)
> Not blockers, but:
> 
> Replacing PERL_INSTALL_ROOT with DESTDIR would seem to be a good idea, given
> the recent fun along those lines :)
>
I don't get the reference, can you point me in the right direction, please ?
 
> Think about including %{?perl_default_filter} by default, even if just pro
> forma.  It won't hurt anything and might save some pain down the line.
> 
I'm about to add that to the devel branch, then probably to F-12 and F-11 too. Not sure yet if the macro is available in EPEL.
Comment 9 Fedora Update System 2010-02-17 08:26:58 UTC 
perl-HTML-Entities-Numbered-0.04-2.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/perl-HTML-Entities-Numbered-0.04-2.fc12
Comment 10 Fedora Update System 2010-02-17 08:27:03 UTC 
perl-HTML-Entities-Numbered-0.04-2.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/perl-HTML-Entities-Numbered-0.04-2.el5
Comment 11 Fedora Update System 2010-02-17 08:27:07 UTC 
perl-HTML-Entities-Numbered-0.04-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/perl-HTML-Entities-Numbered-0.04-2.fc11
Comment 12 Fedora Update System 2010-02-18 07:33:33 UTC 
perl-HTML-Entities-Numbered-0.04-2.el5 has been pushed to the Fedora EPEL 5 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-HTML-Entities-Numbered'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2010-0236
Comment 13 Fedora Update System 2010-02-18 22:40:22 UTC 
perl-HTML-Entities-Numbered-0.04-2.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-HTML-Entities-Numbered'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1435
Comment 14 Fedora Update System 2010-02-18 22:43:38 UTC 
perl-HTML-Entities-Numbered-0.04-2.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-HTML-Entities-Numbered'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-1394
Comment 15 Fedora Update System 2010-03-11 07:20:18 UTC 
perl-HTML-Entities-Numbered-0.04-2.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 16 Fedora Update System 2010-03-11 07:20:31 UTC 
perl-HTML-Entities-Numbered-0.04-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 17 Fedora Update System 2010-03-16 19:35:04 UTC 
perl-HTML-Entities-Numbered-0.04-2.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.