Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 656084 - Review Request: perl-CDB_File - Perl extension for access to cdb databases
Summary: Review Request: perl-CDB_File - Perl extension for access to cdb databases
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-11-23 02:12 UTC by Mark McKinstry
Modified: 2014-10-28 11:00 UTC (History)
3 users (show)

Fixed In Version: perl-CDB_File-0.97-7.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-02-04 18:27:04 UTC
Type: ---
Embargoed:
ppisar: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Mark McKinstry 2010-11-23 02:12:29 UTC 
Spec URL: http://mmckinst.nexcess.net/perl-CDB_File/perl-CDB_File.spec
SRPM URL: http://mmckinst.nexcess.net/perl-CDB_File/perl-CDB_File-0.96-1.fc14.src.rpm
Description: CDB_File is a module which provides a Perl interface to Dan Berstein's
cdb package. cdb is a fast, reliable, lightweight package for creating and 
reading constant databases.


$ rpmlint RPMS/x86_64/perl-CDB_File-0.96-1.fc14.x86_64.rpm 
perl-CDB_File.x86_64: W: spelling-error Summary(en_US) cdb -> cd, db, cab
perl-CDB_File.x86_64: W: spelling-error %description -l en_US cdb -> cd, db, cab
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

$ rpmlint SRPMS/perl-CDB_File-0.96-1.fc14.src.rpm 
perl-CDB_File.src: W: spelling-error Summary(en_US) cdb -> cd, db, cab
perl-CDB_File.src: W: spelling-error %description -l en_US cdb -> cd, db, cab
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Comment 1 Petr Pisar 2010-11-25 13:04:58 UTC 
Source tar ball is original. Ok.
Summary verified from CDB_File.pm. Ok.
License verified from COPYRIGHT. Ok.
Description verified from CDB_File.pm. Ok.

FIX: BuildRequire perl(Exporter) as it can dual-live in the future (CDB_File.pm:8, http://search.cpan.org/~ferreira/Exporter/)
FIX: BuildRequire perl(Test) as it can dual-live in the future (t/01main.t:2, http://search.cpan.org/~jesse/Test/)

All tests pass. Ok.

$ rpmlint perl-CDB_File.spec ../SRPMS/perl-CDB_File-0.96-1.fc14.src.rpm ../RPMS/x86_64/perl-CDB_File-*
perl-CDB_File.src: W: spelling-error Summary(en_US) cdb -> cd, db, cab
perl-CDB_File.src: W: spelling-error %description -l en_US cdb -> cd, db, cab
perl-CDB_File.x86_64: W: spelling-error Summary(en_US) cdb -> cd, db, cab
perl-CDB_File.x86_64: W: spelling-error %description -l en_US cdb -> cd, db, cab
3 packages and 1 specfiles checked; 0 errors, 4 warnings.

rpmlint Ok.

$ rpm -pqlv ../RPMS/x86_64/perl-CDB_File-0.96-1.fc14.x86_64.rpm 
-rw-r--r--    1 root    root                    10339 bře 21  2008 /usr/lib64/perl5/CDB_File.pm
drwxr-xr-x    2 root    root                        0 lis 25 13:45 /usr/lib64/perl5/auto/CDB_File
-rwxr-xr-x    1 root    root                    33224 lis 25 13:45 /usr/lib64/perl5/auto/CDB_File/CDB_File.so
-rwxr-xr-x    1 root    root                     1062 pro  5  2002 /usr/lib64/perl5/bun-x.pl
drwxr-xr-x    2 root    root                        0 lis 25 13:45 /usr/share/doc/perl-CDB_File-0.96
-rw-r--r--    1 root    root                      988 pro  5  2002 /usr/share/doc/perl-CDB_File-0.96/ACKNOWLEDGE
-rw-r--r--    1 root    root                     3096 bře 21  2008 /usr/share/doc/perl-CDB_File-0.96/CHANGES
-rw-r--r--    1 root    root                      131 pro  5  2002 /usr/share/doc/perl-CDB_File-0.96/COPYRIGHT
-rw-r--r--    1 root    root                      340 dub  2  2003 /usr/share/doc/perl-CDB_File-0.96/README
-rw-r--r--    1 root    root                     5868 lis 25 13:45 /usr/share/man/man3/CDB_File.3pm.gz

File permissions and layout Ok.

$ rpm -pq --requires ../RPMS/x86_64/perl-CDB_File-0.96-1.fc14.x86_64.rpm | sort | uniq -c
      1 libc.so.6(GLIBC_2.2.5)(64bit)  
      1 libc.so.6(GLIBC_2.4)(64bit)  
      1 libc.so.6()(64bit)  
      1 perl(Carp)  
      1 perl(CDB_File)  
      1 perl(DynaLoader)  
      1 perl(Exporter)  
      1 perl(:MODULE_COMPAT_5.12.2)  
      1 perl(strict)  
      1 perl(vars)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      2 rpmlib(VersionedDependencies) <= 3.0.3-1
      1 rtld(GNU_HASH)  
      1 /usr/bin/perl  

$ rpm -pq --provides ../RPMS/x86_64/perl-CDB_File-0.96-1.fc14.x86_64.rpm | sort | uniq -c
      1 perl-CDB_File(x86-64) = 0.96-1.fc14
      1 perl(CDB_File) = 0.96
      1 perl-CDB_File = 0.96-1.fc14

$ resolvedeps-f15 ../RPMS/x86_64/perl-CDB_File-*
Binary dependencies Ok.

Otherwise, package is in line with Fedora and perl packaging guidelines.

Package ??? builds in F-15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2625737). ???


Please correct all `FIX' prefixed issues and provide new spec file.
Resolution: Package NOT approved.
Comment 2 Petr Pisar 2010-11-25 13:07:30 UTC 
Package builds in F-15
(http://koji.fedoraproject.org/koji/taskinfo?taskID=2625737). Ok.
Comment 3 Mark McKinstry 2010-11-28 00:55:11 UTC 
Petr,

Thank you for the review.

> FIX: BuildRequire perl(Exporter) as it can dual-live in the future
> (CDB_File.pm:8, http://search.cpan.org/~ferreira/Exporter/)
> FIX: BuildRequire perl(Test) as it can dual-live in the future (t/01main.t:2,
> http://search.cpan.org/~jesse/Test/)

Done.

Spec: http://mmckinst.nexcess.net/perl-CDB_File/perl-CDB_File.spec
SRPM: http://mmckinst.nexcess.net/perl-CDB_File/perl-CDB_File-0.96-2.fc14.src.rpm
Scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=2630358

Can you explain what exactly dual-live means and how you figured out perl(Test) 
and perl(Exporter) needed to be BuildRequires?
Comment 4 Petr Pisar 2010-11-29 09:21:56 UTC 
Spec file changes:

--- perl-CDB_File.spec	2010-11-23 03:00:08.000000000 +0100
+++ perl-CDB_File.spec.1	2010-11-28 01:28:38.000000000 +0100
@@ -2,7 +2,7 @@
 
 Name:           perl-CDB_File
 Version:        0.96
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Perl extension for access to cdb databases
 License:        GPL+ or Artistic
 Group:          Development/Libraries
@@ -10,6 +10,8 @@
 Source0:        http://www.cpan.org/authors/id/M/MS/MSERGEANT/CDB_File-%{version}.tar.gz
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:	perl(Exporter)
+BuildRequires:	perl(Test)
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
 
 %description
@@ -50,5 +52,7 @@
 %{_mandir}/man3/*
 
 %changelog
+* Sat Nov 27 2010 Mark McKinstry <mmckinst> 0.96-2
+- add perl(Exporter) and perl(Test) as build requirements
 * Mon Nov 22 2010 Mark McKinstry <mmckinst> 0.96-1
 - Initial packaging using cpanspec 1.78.


(In reply to comment #3)
> > FIX: BuildRequire perl(Exporter) as it can dual-live in the future
> > (CDB_File.pm:8, http://search.cpan.org/~ferreira/Exporter/)
> > FIX: BuildRequire perl(Test) as it can dual-live in the future (t/01main.t:2,
> > http://search.cpan.org/~jesse/Test/)
> 
> Done.
>
Ok.


$ rpmlint perl-CDB_File.spec ../SRPMS/perl-CDB_File-0.96-2.fc14.src.rpm ../RPMS/x86_64/perl-CDB_File-0.96-2.fc14.x86_64.rpm 
perl-CDB_File.spec:13: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 13)
perl-CDB_File.src: W: spelling-error Summary(en_US) cdb -> cd, db, cab
perl-CDB_File.src: W: spelling-error %description -l en_US cdb -> cd, db, cab
perl-CDB_File.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 13)
perl-CDB_File.x86_64: W: spelling-error Summary(en_US) cdb -> cd, db, cab
perl-CDB_File.x86_64: W: spelling-error %description -l en_US cdb -> cd, db, cab
2 packages and 1 specfiles checked; 0 errors, 6 warnings.

TODO: Normalize white spaces in the spec file.
rpmlint Ok.

Package builds in F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2631600). Ok.


Please consider to correct all `TODO' prefixed issues once committing the package into repository.
Resolution: Package APPROVED.

 
> Can you explain what exactly dual-live means
Dual-lived package means a binary package is built from two SPEC files. Resulting binary packages have the same name (but differs in version) and package utilities (like yum) do not make differences between them.

In perl, we use this approach to upgrade perl modules that come bundled with perl sources. Once user do an update, he needs to download and update only the one package. If we patched the main perl source package, it would change release number of all binary packages made from perl.spec and it would force everybody in update all the resulting binary packages (it counts in tens).

Currently, not all modules bundled with perl have separate binary package, however we try to migrate to this schema as we are upgrading the modules.

Bundled perl packages can be identified by searching CPAN. If there is standalone module name it can be separated into dual-lived RPM package some time. If CPAN points back to `perl' module, the perl module is not just bundled, it's part of perl interpreter sources. I pointed this fact by the URL in parentheses of my comments.

> and how you figured out
> perl(Test) and perl(Exporter) needed to be BuildRequires?

I just greped sources for `use' and `require' keywords. Exact location is the first part inside parentheses of my comments.

I know the cpanspec utility is not aware of it and does not do this exercise. I hope I find a free time to improve it.
Comment 5 Mark McKinstry 2011-01-18 00:58:45 UTC 
New Package SCM Request
=======================
Package Name: perl-CDB_File
Short Description: Perl extension for access to cdb databases
Owners: mmckinst
Branches: f13 f14 f15 el4 el5 el6
Comment 6 Jens Petersen 2011-01-18 07:07:29 UTC 
Git done (by process-git-requests).

f15 is not branched yet
Comment 7 Fedora Update System 2011-01-20 00:07:29 UTC 
perl-CDB_File-0.96-2.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/perl-CDB_File-0.96-2.el5
Comment 8 Fedora Update System 2011-01-20 00:07:36 UTC 
perl-CDB_File-0.96-2.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/perl-CDB_File-0.96-2.fc13
Comment 9 Fedora Update System 2011-01-20 00:07:43 UTC 
perl-CDB_File-0.96-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-CDB_File-0.96-2.fc14
Comment 10 Fedora Update System 2011-01-20 00:07:49 UTC 
perl-CDB_File-0.96-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-CDB_File-0.96-2.el6
Comment 11 Fedora Update System 2011-01-20 00:07:56 UTC 
perl-CDB_File-0.96-2.el4 has been submitted as an update for Fedora EPEL 4.
https://admin.fedoraproject.org/updates/perl-CDB_File-0.96-2.el4
Comment 12 Fedora Update System 2011-01-20 06:30:27 UTC 
perl-CDB_File-0.96-2.el5 has been pushed to the Fedora EPEL 5 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-CDB_File'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/perl-CDB_File-0.96-2.el5
Comment 13 Fedora Update System 2011-02-04 18:26:58 UTC 
perl-CDB_File-0.96-2.el4 has been pushed to the Fedora EPEL 4 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 14 Fedora Update System 2011-02-04 18:28:06 UTC 
perl-CDB_File-0.96-2.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 15 Fedora Update System 2011-02-04 18:28:19 UTC 
perl-CDB_File-0.96-2.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 16 Fedora Update System 2011-02-04 19:49:47 UTC 
perl-CDB_File-0.96-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 17 Fedora Update System 2011-02-04 19:55:17 UTC 
perl-CDB_File-0.96-2.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 18 Mark McKinstry 2014-09-10 01:23:21 UTC 
Package Change Request
======================
Package Name: fpdns
New Branches: epel7
Owners: perl-CDB_File
Comment 19 Mark McKinstry 2014-09-10 01:25:22 UTC 
Package Change Request
======================
Package Name: perl-CDB_File
New Branches: epel7
Owners: mmckinst

scratch comment #18
Comment 20 Gwyn Ciesla 2014-09-10 10:34:09 UTC 
Git done (by process-git-requests).
Comment 21 Fedora Update System 2014-09-12 22:01:35 UTC 
perl-CDB_File-0.97-7.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/perl-CDB_File-0.97-7.el7
Comment 22 Fedora Update System 2014-10-28 11:00:50 UTC 
perl-CDB_File-0.97-7.el7 has been pushed to the Fedora EPEL 7 stable repository.
Note You need to log in before you can comment on or make changes to this bug.