Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 785477 (Horde_Icalendar) - Review Request: php-horde-Horde-Icalendar - iCalendar API
Summary: Review Request: php-horde-Horde-Icalendar - iCalendar API
Keywords:
Status: CLOSED ERRATA
Alias: Horde_Icalendar
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: horde-channel Horde_Translation Horde_Exception Horde_Util Horde_Date Horde_Support Horde_Mime
Blocks: Horde_Data Horde_Timezone Horde_Core Horde_Itip Horde_SyncMl
TreeView+ depends on / blocked
 
Reported: 2012-01-29 03:26 UTC by Nick Bebout
Modified: 2013-03-29 21:27 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-03-29 21:26:56 UTC
Type: ---
Embargoed:
fedora: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)
phpci.log (12.82 KB, text/plain)
2013-03-26 13:35 UTC, Remi Collet 		no flags Details
review.txt (8.92 KB, text/plain)
2013-03-26 13:35 UTC, Remi Collet 		no flags Details
View All

Description Nick Bebout 2012-01-29 03:26:15 UTC 
Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Icalendar.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Icalendar-1.1.1-1.fc16.src.rpm
Description: An API for dealing with iCalendar data.
Comment 1 Nick Bebout 2013-02-06 03:04:17 UTC 
Updated

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Icalendar.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Icalendar-2.0.3-2.fc17.src.rpm
Comment 2 Remi Collet 2013-03-26 13:35:22 UTC 
Created attachment 716524 [details]
phpci.log

phpci version 2.14.0.
Comment 3 Remi Collet 2013-03-26 13:35:55 UTC 
Created attachment 716525 [details]
review.txt

Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 785477
Comment 4 Remi Collet 2013-03-26 13:37:10 UTC 
MUST

[!]: License field in the package spec file matches the actual license.
	LGPLv2

SHOULD (but worth it as we have a blocker)

[!]: Latest version is packaged.
[!]: %check is present and all tests pass.
	version 2.0.4 is relesased which fix tests

COULD (not a blocker, really)

[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed

As Buildroot is removed, both can be removed
Comment 5 Nick Bebout 2013-03-26 21:58:21 UTC 
Updated

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Icalendar.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Icalendar-2.0.4-1.fc17.src.rpm
Comment 6 Remi Collet 2013-03-27 07:55:44 UTC 
-# Need investigation (only fail in mock)
-%global with_tests   %{?_with_tests:1}%{!?_with_tests:0}

[x]: %check is present and all tests pass.

-Version:        2.0.3
-Release:        2%{?dist}
+Version:        2.0.4
+Release:        1%{?dist}

[x]: Latest version is packaged.

-%defattr(-,root,root,-)

[x]: Each %files section contains %defattr if rpm < 4.4

-License:        LGPLv2+
+License:        LGPLv2

[x]: License field in the package spec file matches the actual license.

All blockers fixed.

=== APPROVED ===
Comment 7 Nick Bebout 2013-03-27 08:49:12 UTC 
New Package SCM Request
=======================
Package Name: php-horde-Horde-Icalendar
Short Description: Horde iCalendar API
Owners: nb remi
Branches: el6 f18 f19
InitialCC:
Comment 8 Gwyn Ciesla 2013-03-27 12:34:12 UTC 
Git done (by process-git-requests).
Comment 9 Fedora Update System 2013-03-27 21:25:02 UTC 
php-horde-Horde-Mime-2.0.4-2.fc18, php-horde-Horde-Perms-2.1.0-1.fc18, php-horde-Horde-Prefs-2.3.2-2.fc18, php-horde-Horde-Data-2.0.3-3.fc18, php-horde-Horde-Icalendar-2.0.4-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/php-horde-Horde-Icalendar-2.0.4-1.fc18,php-horde-Horde-Data-2.0.3-3.fc18,php-horde-Horde-Prefs-2.3.2-2.fc18,php-horde-Horde-Perms-2.1.0-1.fc18,php-horde-Horde-Mime-2.0.4-2.fc18
Comment 10 Fedora Update System 2013-03-27 21:38:35 UTC 
php-horde-Horde-Mime-2.0.4-2.el6, php-horde-Horde-Prefs-2.3.2-2.el6, php-horde-Horde-Data-2.0.3-3.el6, php-horde-Horde-Perms-2.1.0-1.el6, php-horde-Horde-Icalendar-2.0.4-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-horde-Horde-Icalendar-2.0.4-1.el6,php-horde-Horde-Perms-2.1.0-1.el6,php-horde-Horde-Data-2.0.3-3.el6,php-horde-Horde-Prefs-2.3.2-2.el6,php-horde-Horde-Mime-2.0.4-2.el6
Comment 11 Fedora Update System 2013-03-29 21:27:00 UTC 
php-horde-Horde-Mime-2.0.4-2.el6, php-horde-Horde-Prefs-2.3.2-2.el6, php-horde-Horde-Data-2.0.3-3.el6, php-horde-Horde-Perms-2.1.0-1.el6, php-horde-Horde-Icalendar-2.0.4-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
Note You need to log in before you can comment on or make changes to this bug.