Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 819913 - koan should require python-ethtool
Summary: koan should require python-ethtool
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: cobbler
Version: 17
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: James C.
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-05-08 15:34 UTC by Orion Poplawski
Modified: 2012-05-22 16:02 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1638933 (view as bug list)
Environment:
Last Closed: 2012-05-22 02:05:56 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Orion Poplawski 2012-05-08 15:34:28 UTC 
Description of problem:

# koan --replace-self
- looking for Cobbler at http://cobbler.cora.nwra.com:80/cobbler_api
the rhpl or ethtool module is required to use this feature (is your OS>=EL3?)

Version-Release number of selected component (if applicable):
koan-2.2.2-1.fc17.noarch
Comment 1 James C. 2012-05-22 02:05:56 UTC 
This is not required because it's an either/or situation:

def get_network_info():
   try:
      import ethtool
   except:
      try:
         import rhpl.ethtool
         ethtool = rhpl.ethtool
      except:
           raise InfoException("the rhpl or ethtool module is required to use this feature (is your OS>=EL3?)")


Adding a requirement on one would exclude the other, so neither are required and the import error is handled gracefully with a suggestion to install the one available for your distro.
Comment 2 James C. 2012-05-22 02:08:23 UTC 
This is not required because it's an either/or situation:

def get_network_info():
   try:
      import ethtool
   except:
      try:
         import rhpl.ethtool
         ethtool = rhpl.ethtool
      except:
           raise InfoException("the rhpl or ethtool module is required to use this feature (is your OS>=EL3?)")


Adding a requirement on one would exclude the other, so neither are required and the import error is handled gracefully with a suggestion to install the one available for your distro.
Comment 3 Orion Poplawski 2012-05-22 16:02:08 UTC 
I disagree.  I filed this bug against *Fedora*, not cobbler in general.  In Fedora, there is no rhpl.ethtool, only python-ethtool, and it should be required by the Fedora koan package.
Note You need to log in before you can comment on or make changes to this bug.