Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 910136 - Review Request: nodejs-node-expat - Fast libexpat XML SAX parser binding for Node.js
Summary: Review Request: nodejs-node-expat - Fast libexpat XML SAX parser binding for ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tom Hughes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 910145 910147 910154 911022
TreeView+ depends on / blocked
 
Reported: 2013-02-11 21:31 UTC by Jamie Nguyen
Modified: 2013-04-07 00:21 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-03-19 14:12:30 UTC
Type: ---
Embargoed:
tom: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jamie Nguyen 2013-02-11 21:31:06 UTC
Spec URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/nodejs-node-expat.spec
SRPM URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/SRPMS/nodejs-node-expat-2.0.0-1.fc18.src.rpm
Fedora Account System Username: jamielinux

Description:
Fast libexpat XML SAX parser binding for Node.js.

Comment 1 Tom Hughes 2013-03-10 17:15:55 UTC
Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package contains no bundled libraries without FPC exception

The deps directory should be removed in %setup and the package patched
to link against the system libexpat.

- Permissions on files are set properly.

nodejs-node-expat.x86_64: E: non-standard-executable-perm /usr/lib/node_modules/node-expat/build/node_expat.node 0775L


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "MIT/X11 (BSD like)", "GPL (v2 or later)", "Unknown or generated". 3
     files have unknown license. Detailed output of licensecheck in
     /home/tom/910136-nodejs-node-expat/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: nodejs-node-expat-2.0.0-1.fc19.x86_64.rpm
nodejs-node-expat.x86_64: W: spelling-error Summary(en_US) libexpat -> lib expat, lib-expat, liberate
nodejs-node-expat.x86_64: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-node-expat.x86_64: W: spelling-error %description -l en_US libexpat -> lib expat, lib-expat, liberate
nodejs-node-expat.x86_64: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-node-expat.x86_64: E: non-standard-executable-perm /usr/lib/node_modules/node-expat/build/node_expat.node 0775L
1 packages and 0 specfiles checked; 1 errors, 4 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint nodejs-node-expat
nodejs-node-expat.x86_64: W: spelling-error Summary(en_US) libexpat -> lib expat, lib-expat, liberate
nodejs-node-expat.x86_64: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-node-expat.x86_64: W: spelling-error %description -l en_US libexpat -> lib expat, lib-expat, liberate
nodejs-node-expat.x86_64: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-node-expat.x86_64: E: non-standard-executable-perm /usr/lib/node_modules/node-expat/build/node_expat.node 0775L
1 packages and 0 specfiles checked; 1 errors, 4 warnings.
# echo 'rpmlint-done:'



Requires
--------
nodejs-node-expat (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    nodejs(engine)
    rtld(GNU_HASH)
    v8



Provides
--------
nodejs-node-expat:
    node_expat.node()(64bit)
    nodejs-node-expat
    nodejs-node-expat(x86-64)
    npm(node-expat)



MD5-sum check
-------------
http://registry.npmjs.org/node-expat/-/node-expat-2.0.0.tgz :
  CHECKSUM(SHA256) this package     : 9d5b7efd708fc546f5c17e98f4ee322abafaaa02fbb6c281f651d10d9523c83f
  CHECKSUM(SHA256) upstream package : 9d5b7efd708fc546f5c17e98f4ee322abafaaa02fbb6c281f651d10d9523c83f


Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -x CheckNoNameConflict -m fedora-rawhide-x86_64 -b 910136

Comment 2 Jamie Nguyen 2013-03-10 18:17:59 UTC
> - Package contains no bundled libraries without FPC exception
>
> The deps directory should be removed in %setup and the package patched
> to link against the system libexpat.

Oops. Fixed and all tests still pass.


> - Permissions on files are set properly.
> 
> nodejs-node-expat.x86_64: E: non-standard-executable-perm /usr/lib/node_modules/node-expat/build/node_expat.node 0775L

Fixed.


Spec URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/nodejs-node-expat.spec
SRPM URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/SRPMS/nodejs-node-expat-2.0.0-2.fc18.src.rpm

Comment 3 Tom Hughes 2013-03-10 18:37:44 UTC
Looks good. Package approved.

Comment 4 Jamie Nguyen 2013-03-10 18:41:29 UTC
New Package SCM Request
=======================
Package Name: nodejs-node-expat
Short Description: Fast libexpat XML SAX parser binding for Node.js
Owners: jamielinux
Branches: f18 el6
InitialCC:

Comment 5 Gwyn Ciesla 2013-03-11 12:17:18 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2013-03-11 22:13:55 UTC
nodejs-node-expat-2.0.0-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/nodejs-node-expat-2.0.0-2.fc18

Comment 7 Fedora Update System 2013-03-12 08:33:54 UTC
nodejs-node-expat-2.0.0-2.fc18 has been pushed to the Fedora 18 testing repository.

Comment 8 Fedora Update System 2013-03-15 10:59:48 UTC
nodejs-node-expat-2.0.0-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/nodejs-node-expat-2.0.0-3.fc18

Comment 9 Fedora Update System 2013-03-20 22:13:36 UTC
nodejs-node-expat-2.0.0-4.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/nodejs-node-expat-2.0.0-4.fc18

Comment 10 Fedora Update System 2013-04-07 00:21:06 UTC
nodejs-node-expat-2.0.0-4.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.