Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 921335 (CVE-2013-1857) - CVE-2013-1857 rubygem-actionpack: sanitize_protocol: XSS Vulnerability in the helper of Ruby on Rails
Summary: CVE-2013-1857 rubygem-actionpack: sanitize_protocol: XSS Vulnerability in the...
Keywords:
Status: CLOSED ERRATA
Alias: CVE-2013-1857
Product: Security Response
Classification: Other
Component: vulnerability
Version: unspecified
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Red Hat Product Security
QA Contact:
URL:
Whiteboard:
Depends On: 924297 924298 995658 1030779 1165372 1165373
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-03-14 03:02 UTC by Kurt Seifried
Modified: 2023-05-13 01:16 UTC (History)
22 users (show)

Fixed In Version: rubygem-actionpack 3.1.12, rubygem-actionpack 3.2.13
Clone Of:
Environment:
Last Closed: 2015-01-17 05:34:02 UTC
Embargoed:


Attachments (Terms of Use)
2-3-sanitize_protocol.patch (deleted)
2013-03-14 20:33 UTC, Kurt Seifried
no flags Details | Diff
3-0-sanitize_protocol.patch (deleted)
2013-03-14 20:33 UTC, Kurt Seifried
no flags Details | Diff
3-1-sanitize_protocol.patch (deleted)
2013-03-14 20:33 UTC, Kurt Seifried
no flags Details | Diff
3-2-sanitize_protocol.patch (deleted)
2013-03-14 20:34 UTC, Kurt Seifried
no flags Details | Diff
2-3-sanitize_protocol.patch (deleted)
2013-03-18 05:31 UTC, Kurt Seifried
no flags Details | Diff
3-0-sanitize_protocol.patch (deleted)
2013-03-18 05:32 UTC, Kurt Seifried
no flags Details | Diff
3-1-sanitize_protocol.patch (deleted)
2013-03-18 05:33 UTC, Kurt Seifried
no flags Details | Diff
3-2-sanitize_protocol.patch (deleted)
2013-03-18 05:33 UTC, Kurt Seifried
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2013:0698 0 normal SHIPPED_LIVE Moderate: rubygem-actionpack and ruby193-rubygem-actionpack security update 2013-04-02 23:45:32 UTC
Red Hat Product Errata RHSA-2014:1863 0 normal SHIPPED_LIVE Important: Subscription Asset Manager 1.4 security update 2014-11-17 22:08:19 UTC

Description Kurt Seifried 2013-03-14 03:02:16 UTC
XSS Vulnerability in the `sanitize` helper of Ruby on Rails

There is an XSS vulnerability in the sanitize helper in Ruby on Rails. This vulnerability has been assigned the CVE identifier CVE-2013-1857.

Versions Affected:  All.
Not affected:       None.
Fixed Versions:     3.2.13, 3.1.12

Impact
------
The sanitize helper in Ruby on Rails is designed to filter HTML and remove all tags and attributes which could be malicious.  The code which ensured that URLs only contain supported protocols contained several bugs which could allow an attacker to embed a tag containing a URL which executes arbitrary javascript code.

All users running an affected release should either upgrade or use one of the work arounds immediately.

Releases
--------
The 3.2.13 and 3.1.12 releases are available at the normal locations.

Workarounds
-----------
If you are unable to upgrade, you can place the following code into a file in config/initializers and it will replace the method with the correct implementation.

  module HTML
    class WhiteListSanitizer
      def contains_bad_protocols?(attr_name, value)
        uri_attributes.include?(attr_name) &&
        (value =~ /(^[^\/:]*):|(&#0*58)|(&#x3a)|(&#x70)|(%|%)3A/i && !allowed_protocols.include?(value.split(protocol_separator).first.downcase.strip))
      end
    end
  end



Patches
-------
To aid users who aren't able to upgrade immediately we have provided patches for the two supported release series.  They are in git-am format and consist of a single changeset.

* 3-2-sanitize_protocol.patch - Patch for 3.2 series
* 3-1-sanitize_protocol.patch - Patch for 3.1 series
* 3-0-sanitize_protocol.patch - Patch for 3.0 series
* 2-3-sanitize_protocol.patch - Patch for 2.3 series

Please note that only the 3.1.x and 3.2.x series are supported at present.  Users of earlier unsupported releases are advised to upgrade as soon as possible as we cannot guarantee the continued availability of security fixes for unsupported releases.

Credits
-------

Thanks to Alan Jenkins for reporting the vulnerability to us.

Comment 3 Kurt Seifried 2013-03-14 20:33:08 UTC
Created attachment 710233 [details]
2-3-sanitize_protocol.patch

Comment 4 Kurt Seifried 2013-03-14 20:33:25 UTC
Created attachment 710234 [details]
3-0-sanitize_protocol.patch

Comment 5 Kurt Seifried 2013-03-14 20:33:46 UTC
Created attachment 710235 [details]
3-1-sanitize_protocol.patch

Comment 6 Kurt Seifried 2013-03-14 20:34:05 UTC
Created attachment 710236 [details]
3-2-sanitize_protocol.patch

Comment 8 Kurt Seifried 2013-03-16 05:27:33 UTC
Please note that upstream reports that the patches have an issue and will be reissued this weekend most likely so we might need to respin this fix.

Comment 9 Kurt Seifried 2013-03-18 05:31:59 UTC
Created attachment 711753 [details]
2-3-sanitize_protocol.patch

Comment 10 Kurt Seifried 2013-03-18 05:32:28 UTC
Created attachment 711754 [details]
3-0-sanitize_protocol.patch

Comment 11 Kurt Seifried 2013-03-18 05:33:07 UTC
Created attachment 711755 [details]
3-1-sanitize_protocol.patch

Comment 12 Kurt Seifried 2013-03-18 05:33:53 UTC
Created attachment 711756 [details]
3-2-sanitize_protocol.patch

Comment 14 Vít Ondruch 2013-03-21 14:00:02 UTC
Can I get tracking bug for F1{7,8}? Thank you.

Comment 15 Jan Lieskovsky 2013-03-21 14:14:56 UTC
Created rubygem-actionpack tracking bugs for this issue

Affects: epel-5 [bug 924297]
Affects: fedora-all [bug 924298]

Comment 16 Murray McAllister 2013-03-27 11:28:55 UTC
Acknowledgements:

Red Hat would like to thank Ruby on Rails upstream for reporting this issue. Upstream acknowledges Alan Jenkins as the original reporter.

Comment 17 errata-xmlrpc 2013-04-02 19:47:28 UTC
This issue has been addressed in following products:

  RHEL 6 Version of OpenShift Enterprise

Via RHSA-2013:0698 https://rhn.redhat.com/errata/RHSA-2013-0698.html

Comment 18 Kurt Seifried 2013-07-26 06:16:49 UTC
The Red Hat Security Response Team has rated this issue as having moderate security impact in CloudForms 1.1. This issue is not currently planned to be addressed in future updates.

Comment 22 Martin Prpič 2014-11-14 16:20:25 UTC
IssueDescription:

A cross-site scripting (XSS) flaw was found in Action Pack. A remote attacker could use this flaw to conduct XSS attacks against users of an application using Action Pack.

Comment 23 errata-xmlrpc 2014-11-17 17:08:51 UTC
This issue has been addressed in the following products:

  Red Hat Subscription Asset Manager 1.4

Via RHSA-2014:1863 https://rhn.redhat.com/errata/RHSA-2014-1863.html


Note You need to log in before you can comment on or make changes to this bug.