Automated result from review-o-matic.

Koji Scratch build error.
Read the log at http://koji.fedoraproject.org/koji/getfile?taskID=886950&name=root.log

ping - original package submission is gone

Here is my spec and srpm

http://zoglesby.fedorapeople.org/xmobar.spec
http://zoglesby.fedorapeople.org/xmobar-0.9.2-1.fc11.src.rpm

Sorry update to cabal2spec-0.16 or later.

Updated with cabal2spec-0.16

http://zoglesby.fedorapeople.org/xmobar.spec
http://zoglesby.fedorapeople.org/xmobar-0.9.2-2.fc11.src.rpm

I guess you want to depend on utf8-string, X11-xft,  and hinotify?

Though utf8-string (already in fedora), X11-xft, and hinotify are optional, so we could also proceed with this and add the optional builds later.

Updated to include ghc-X11 and ghc-utf8-string as deps, also stopped making up groups.

http://zoglesby.fedorapeople.org/xmobar-0.9.2-3.fc11.src.rpm
http://zoglesby.fedorapeople.org/xmobar.spec

xmobar.src: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 21)

Created attachment 366582 [details]
xmobar.spec-1.patch

You don't need doc/prof for a binary only package, plus other minor fixes.

Ping. Status update on this?

ping-a-ling?

Yaakov interested in taking this back? ;)

New upstream release:
http://hackage.haskell.org/package/xmobar-0.11.1

Anyone want to pick this up?

I may take this; if I get around to it over the break before graduation and no one else has taken it, I'll pick it up.

I am wating on a new computer to arrive from Dell either this week or next and then I will update this package.

ping anyone?

If noone else wants to I may submit a new package...

I'll take it. I have libmpd to do as well at least. Can do without the optional deps for now though:

Spec: http://benboeckel.net/packaging/xmobar/xmobar.spec
SRPM: http://benboeckel.net/packaging/xmobar/xmobar-0.11.1-1.fc14.src.rpm

% lintmock fedora-14-x86_64-bb
xmobar.src: W: spelling-error Summary(en_US) minimalistic -> minimalist, Minimalist, minimalism
xmobar.src: W: spelling-error %description -l en_US plugins -> plug ins, plug-ins, plugging
xmobar.src: W: strange-permission xmobar-0.11.1.tar.gz 0640L
xmobar.src: W: strange-permission xmobar.spec 0640L
xmobar.src: W: no-buildroot-tag
xmobar.x86_64: W: spelling-error Summary(en_US) minimalistic -> minimalist, Minimalist, minimalism
xmobar.x86_64: W: spelling-error %description -l en_US plugins -> plug ins, plug-ins, plugging
xmobar.x86_64: W: no-manual-page-for-binary xmobar
2 packages and 0 specfiles checked; 0 errors, 8 warnings.

Spec: http://benboeckel.net/packaging/xmobar/xmobar.spec
SRPM: http://benboeckel.net/packaging/xmobar/xmobar-0.11.1-2.fc14.src.rpm

Update to ship xmonadpropwrite as well.

Ok thanks.  Here is the review:

 +:ok, !:needs attention,  NA: not applicable

MUST Items:
[+] MUST: rpmlint output

xmobar.src: W: spelling-error Summary(en_US) minimalistic -> Minimalist, minimalist, minimalism
xmobar.src: W: spelling-error %description -l en_US plugins -> plug ins, plug-ins, plugging
xmobar.src: W: strange-permission xmobar-0.11.1.tar.gz 0640L
xmobar.src: W: strange-permission xmobar.spec 0640L
xmobar.src: W: no-buildroot-tag
1 packages and 0 specfiles checked; 0 errors, 5 warnings.
xmobar.x86_64: W: spelling-error Summary(en_US) minimalistic -> Minimalist, minimalist, minimalism
xmobar.x86_64: W: spelling-error %description -l en_US plugins -> plug ins, plug-ins, plugging
xmobar.x86_64: W: executable-stack /usr/bin/xmobar
xmobar.x86_64: W: executable-stack /usr/bin/xmonadpropwrite
xmobar.x86_64: W: no-manual-page-for-binary xmonadpropwrite
xmobar.x86_64: W: no-manual-page-for-binary xmobar
1 packages and 0 specfiles checked; 0 errors, 6 warnings.

Ok

[+] MUST: Package Naming Guidelines
[+] MUST: spec file name must match base package %{name}
[+] MUST: Packaging Guidelines.
[+] MUST: Licensing Guidelines
[+] MUST: License field in the package spec file must match actual license.
[+] MUST: include license files in %doc if available in source
[+] MUST: The spec file must be written in American English and be legible.
[+] MUST: source md5sum matches upstream release

766fe504909384628321fb7472fdb621  xmobar-0.11.1.tar.gz

[+] MUST: must successfully compile and build into binary rpms on one main arch

http://koji.fedoraproject.org/koji/taskinfo?taskID=2442474

[+] MUST: if necessary use ExcludeArch for other archs
[+] MUST: All build dependencies must be listed in BuildRequires
[NA] MUST: use %find_lang macro for .po translations
[NA] MUST: packages which store shared library files in the dynamic linker's default paths, must call ldconfig in %post and %postun.
[NA] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review
[+] MUST: A package must own all directories that it creates.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissable content.
[NA] MUST: Large documentation files should go in a doc subpackage.
[+] MUST: If a package includes something as %doc, it must not affect the runtime of the application.
[NA] MUST: Header files must be in a -devel package.
[NA] MUST: Static libraries must be in a -static package.
[NA] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package.
[!] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section.

It would be best to add a desktop file.

[+] MUST: Packages must not own files or directories already owned by other packages.
[+] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: All filenames in rpm packages must be valid UTF-8.

Please also include the useful README file.

Basically all fine but since this is a GUI program I think it needs
a desktop file.  You could probably take the one we added for
xmonad as a starting point.

Spec: http://benboeckel.net/packaging/xmobar/xmobar.spec
SRPM: http://benboeckel.net/packaging/xmobar/xmobar-0.11.1-4.fc14.src.rpm

Added README, enabled libmpd and hinotify (reviews finished now), and ship a desktop file.

% lintmock fedora-14-x86_64-bb
xmobar.src: W: spelling-error Summary(en_US) minimalistic -> minimalist, Minimalist, minimalism
xmobar.src: W: spelling-error %description -l en_US plugins -> plug ins, plug-ins, plugging
xmobar.src: W: strange-permission xmobar.desktop 0640L
xmobar.src: W: strange-permission xmobar-0.11.1.tar.gz 0640L
xmobar.src: W: strange-permission xmobar.spec 0640L
xmobar.x86_64: W: spelling-error Summary(en_US) minimalistic -> minimalist, Minimalist, minimalism
xmobar.x86_64: W: spelling-error %description -l en_US plugins -> plug ins, plug-ins, plugging
xmobar.x86_64: W: no-manual-page-for-binary xmonadpropwrite
xmobar.x86_64: W: no-manual-page-for-binary xmobar
2 packages and 0 specfiles checked; 0 errors, 9 warnings

Thanks - looks good to me now.
I think you can drop Icon line from the .desktop file,
unless some free icon exists (I couldn't find any).

APPROVED

New Package CVS Request
=======================
Package Name: xmobar
Short Description: A minimalistic text-based status bar
Owners: mathstuf
Branches: F-13 F-14
InitialCC: haskell-sig

Needs a flag set…

Git done (by process-git-requests).

xmobar-0.11.1-4.fc14,ghc-libmpd-0.4.2-1.fc14,ghc-hinotify-0.3.1-4.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/xmobar-0.11.1-4.fc14,ghc-libmpd-0.4.2-1.fc14,ghc-hinotify-0.3.1-4.fc14

xmobar-0.11.1-4.fc13,ghc-libmpd-0.4.2-1.fc13,ghc-hinotify-0.3.1-4.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/xmobar-0.11.1-4.fc13,ghc-libmpd-0.4.2-1.fc13,ghc-hinotify-0.3.1-4.fc13

xmobar-0.11.1-4.fc14, ghc-libmpd-0.4.2-1.fc14, ghc-hinotify-0.3.1-4.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update xmobar ghc-libmpd ghc-hinotify'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/xmobar-0.11.1-4.fc14,ghc-libmpd-0.4.2-1.fc14,ghc-hinotify-0.3.1-4.fc14

xmobar-0.11.1-4.fc14, ghc-libmpd-0.4.2-1.fc14, ghc-hinotify-0.3.1-4.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

xmobar-0.11.1-4.fc13, ghc-libmpd-0.4.2-1.fc13, ghc-hinotify-0.3.1-4.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.