Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1008527 (qt5-qtquickcontrols)
| Summary: | Review Request: qt5-qtquickcontrols - Qt5 - module with set of QtQuick controls | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Rintel <lkundrak> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | ablu.erikschilling, i, kevin, notting, pierluigi.fiorini, rdieter |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | rdieter:
fedora-review+
gwync: fedora-cvs+ |
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | qt5-qtquickcontrols-5.1.1-2.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-10-14 07:01:43 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 928937 | ||
|
Description
Lubomir Rintel
2013-09-16 14:28:55 UTC
What's your FAS username? (In reply to Christopher Meng from comment #1) > What's your FAS username? lkundrak Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5969150 $ rpmlint *.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. naming: ok licensing: ok ... mostly. you could probably drop BSD reference since that is only used in (currently unpackaged) examples. macros: ok scriptlets: ok builds/installs: ok One small nit: 1 SHOULD drop unused %package devel stanza But that can be easily fixed post-review. APPROVED. Also, to match qt5-qtquick1 (and friends), you'll want to add:
ExclusiveArch: %{ix86} x86_64 %{arm}
Thank you for the review. All SHOULD items you noticed seem legitimate to me and I'll address them upon import. New Package SCM Request ======================= Package Name: qt5-qtquickcontrols Short Description: module with set of QtQuick controls Owners: lkundrak rdieter than jreznik kkofler ltinkl rnovacek Branches: f18 f19 f20 el6 Git done (by process-git-requests). Imported and built. Thank you Rex, thank you Jon! qt5-qtquickcontrols-5.1.1-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/qt5-qtquickcontrols-5.1.1-2.fc19 qt5-qtquickcontrols-5.1.1-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/qt5-qtquickcontrols-5.1.1-2.fc18 qt5-qtquickcontrols-5.1.1-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/qt5-qtquickcontrols-5.1.1-2.el6 qt5-qtquickcontrols-5.1.1-2.fc18 has been pushed to the Fedora 18 testing repository. qt5-qtquickcontrols-5.1.1-2.fc18 has been pushed to the Fedora 18 stable repository. qt5-qtquickcontrols-5.1.1-2.fc19 has been pushed to the Fedora 19 stable repository. qt5-qtquickcontrols-5.1.1-2.fc19 has been pushed to the Fedora 19 stable repository. qt5-qtquickcontrols-5.1.1-2.fc18 has been pushed to the Fedora 18 stable repository. qt5-qtquickcontrols-5.1.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository. |