Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1015958
Summary: | Review Request: fst - run VST plugins under wine | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Brendan Jones <brendan.jones.it> |
Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | i, package-review, rc040203, zbyszek |
Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | lv2-triceratops-0.1.7-1.fc20 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-12-28 05:23:56 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 805236, 1016444 |
Description
Brendan Jones
2013-10-07 06:41:38 UTC
Should use URL tag but not Url. (In reply to Christopher Meng from comment #1) > Should use URL tag but not Url. Not true - Both are equivalent. There is no technical reason to force packagers to using URL. (In reply to Ralf Corsepius from comment #2) > (In reply to Christopher Meng from comment #1) > > Should use URL tag but not Url. > Not true - Both are equivalent. There is no technical reason to force > packagers to using URL. Then you should clean some reviewers who have told me this is wrong. 1. Please use %{commit} for the sha1. 2. Please use http://repo.or.cz/w/%{name}.git/snapshot/%{commit}.tar.gz for Source0 and remove snapshot.sh. 3. Can you extend the %description a bit: for people who know very little about audio (like your reviewer :)), a hint what is VST would be helpful. Also, this package seems to be a library (because it has a -devel counterpart), but also a tool, since it is used to "run" things. 4. Use 'make CFLAGS=...' not 'CFLAGS=... make'. 5. Use 'make %{?_smp_mflags} ...', unless parallel build is not supported, in which case add a note. 6. Are those explicit permissions necessary? I'm pretty sure that plain 'mkdir -p' for dirs and 'cp -p' for files should work. 7. Doesn't build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6096872 ;( I've made all the changes you've suggested. The headers are required for hosts to be able to query plugin contents, albeit without the requirement of the binary in the main package. Build failing because I can't pull in 32 bit packages into the 64 bit buildroot. Changed to exclusively i686. http://koji.fedoraproject.org/koji/taskinfo?taskID=6097152 SRPM: http://bsjones.fedorapeople.org/reviews/fst-1.9-0.1.20110131git20661444.fc20.src.rpm SPEC: http://bsjones.fedorapeople.org/reviews/fst.spec 1. Please also replace 20661444 in Release by %{commit}. 2. the comment about snapshot.sh is not needed 3. the description... 5. Use 'make %{?_smp_mflags} ...'... 6. Please add %doc COPYING README Rpmlint says: fst.i686: W: incoherent-version-in-changelog 1.8-0.2.20110131git20661444 ['1.9-0.1.20110131git20661444.fc20', '1.9-0.1.20110131git20661444'] Hm, I should test if this works... Not so easy. Will try tomorrow. OK, so it seems to launch correctly. Please fix the issues noted above. OK, all updated here: SRPM: http://bsjones.fedorapeople.org/reviews/fst-1.9-0.2.20110131git20661444.fc20.src.rpm SPEC: http://bsjones.fedorapeople.org/reviews/fst.spec Scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=6101384 License OK, license file included. Builds OK, even if only on i686. Packaging is OK. Latest version is packaged. rpmlint: fst.i686: E: incorrect-fsf-address /usr/share/doc/fst/COPYING fst.i686: W: no-manual-page-for-binary fst.exe fst.src: W: file-size-mismatch 2066144.tar.gz = 36104, http://repo.or.cz/w/fst.git/snapshot/2066144.tar.gz = 0 Eh, the URL works. fst-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/fst/jfst.c fst-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/fst/audiomaster.c fst-devel.i686: W: no-documentation 4 packages and 0 specfiles checked; 3 errors, 3 warnings. Notify the upstream about outdated FSF address at your discretion. Package is APPROVED. Thank you for the review! New Package SCM Request ======================= Package Name: fst Short Description: Run VST audio plugins under Wine Owners: bsjones Branches: f18 f19 f20 InitialCC: -EFLAGERROR :) Git done (by process-git-requests). CLOASED as RAWHIDE? Brendan, I closed this bug as RAWHIDE because I haven't see any builds for f20 or f19. Thanks. lv2-triceratops-0.1.7-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/lv2-triceratops-0.1.7-1.fc19 lv2-triceratops-0.1.7-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/lv2-triceratops-0.1.7-1.fc20 lv2-triceratops-0.1.7-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |