Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1016444 (festige) - ReviewRequest: festige - a GUI frontend to fst and dssi vst (run Windows VST audio plugins under wine)
Summary: ReviewRequest: festige - a GUI frontend to fst and dssi vst (run Windows VST ...
Keywords:
Status: CLOSED NOTABUG
Alias: festige
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1015958
Blocks: FE-DEADREVIEW FedoraAudio qt-reviews
TreeView+ depends on / blocked
 
Reported: 2013-10-08 07:54 UTC by Brendan Jones
Modified: 2017-07-25 10:38 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-10-17 20:18:44 UTC
Type: Bug
Embargoed:
brendan.jones.it: needinfo-


Attachments (Terms of Use)

Description Brendan Jones 2013-10-08 07:54:12 UTC
festige is a GUI for fst and dssi-vst,
allowing you to run Windows VST plugins on Linux

Optionally supports ladish sessions (bug 865699)

SRPM: http://bsjones.fedorapeople.org/reviews/festige-1.0.2-1.src.rpm
SPEC: http://bsjones.fedorapeople.org/reviews/festige.spec

Comment 1 Brendan Jones 2013-10-08 07:56:51 UTC
fst (bug 1015958) is only a runtime requirement and need not hold up this review

Comment 2 Eduardo Mayorga 2014-02-04 21:59:59 UTC
Some quick comments:
* Use %{name} macro in %prep
* Add COPYING and README files as %doc
* Group tag is deprecated
* Just add one package per BuildRequire tag line

I'm not an official packager so this is just an informal review.

Comment 3 Volker Fröhlich 2014-02-11 00:22:28 UTC
You should BR qt4-devel. However, PyQt4-devel transitively requires qt4-devel anyway, so you can drop it. I'm not sure what the Python modules are necessary for. BR python2 is not necessary.

Use the name macro for patches, use the name and version macro in URL. The spec file and the spec file from the RPM don't match.

You should rather delete fst in the prep section.

Please add COPYING and README as %doc.

The optflags are useless there, as nothing should be compiled.

Can you find a more elegant solution than symlinks?

With fst only being available on i686, the build of this package should be excluded too.

Will it work with Python 3?

sed -i -e 's/Qt/Sequencer/' %{buildroot}%{_datadir}/applications/%{name}.desktop -- Ideally you should not edit the desktop file manually, but through the desktop utils. However, this can go to the prep section.

The README file says:

----- COMPILE:
In order to use FeSTige, you first have to compile it.
You'll need the devel packages of:
  - Python
  - PyQt4
  - Qt4
  - Wine
  - Gtk

That seems wrong and you should let the author know, if he's still active. 
Can you get your changes upstream?

Comment 4 Kevin Kofler 2014-02-11 00:30:42 UTC
This package can also be built for x86_64, using the i686-only fst that hopefully ends up in the x86_64 repository as a multilib. But any non-x86 architectures are indeed hosed, so it needs an ExclusiveArch.

Comment 5 Raphael Groner 2016-07-15 16:18:55 UTC
Hi requester,
are you still interested in this package? Maybe in doing a review swap?

Comment 6 Raphael Groner 2016-10-17 20:18:44 UTC
I'll close here. This request looks really dead to me, no response from requester since years.


Note You need to log in before you can comment on or make changes to this bug.