Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1048040 (qt5-qtserialport)
| Summary: | Review Request: qt5-qtserialport - Qt5 Serialport component | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | kevin, lkundrak, package-review |
| Target Milestone: | --- | Flags: | lkundrak:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | qt5-qtserialport-5.2.0-1.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-01-17 05:47:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 928937 | ||
|
Description
Rex Dieter
2014-01-03 00:54:04 UTC
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6353143 0.) You may want to use a bcond here; so that it's a bit more readable and rpmbuild --without works:
# define to build docs, need to undef this for bootstrapping
%define docs 1
...
%if 0%{?docs}
%bcond_without docs
...
%if %with docs
1.) You may want to %exclude this one:
qt5-qtserialport-doc.noarch: E: zero-length /usr/share/doc/qt5/qtserialport/demos-manifest.xml
* Package is named correctly
* Packaging the latest version
* Good license, full text present
* License tag correct
* Rpmlint mostly happy (see above)
* Requires file
* Provides fine
* Filelist fine
* SPEC file clean and legible, fairly standard Qt5 package
APPROVED
New Package SCM Request ======================= Package Name: qt5-qtserialport Short Description: Qt5 - Serialport component Owners: than rdieter jreznik kkofler ltinkl rnovacek Branches: el6 f19 f20 InitialCC: Git done (by process-git-requests). qt5-qtserialport-5.2.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/qt5-qtserialport-5.2.0-1.el6 qt5-qtserialport-5.2.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/qt5-qtserialport-5.2.0-1.fc20 qt5-qtserialport-5.2.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/qt5-qtserialport-5.2.0-1.fc19 qt5-qtserialport-5.2.0-1.el6 has been pushed to the Fedora EPEL 6 testing repository. qt5-qtserialport-5.2.0-1.fc19 has been pushed to the Fedora 19 stable repository. qt5-qtserialport-5.2.0-1.fc20 has been pushed to the Fedora 20 stable repository. qt5-qtserialport-5.2.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. |