Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1062237 (polkit-qt5-1)
| Summary: | Review Request: polkit-qt5-1 - Qt5 bindings for PolicyKit | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Rintel <lkundrak> |
| Component: | Package Review | Assignee: | Maros Zatko <mzatko> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | dvratil, kevin, lkundrak, mbriza, mzatko, package-review, rdieter |
| Target Milestone: | --- | Flags: | mzatko:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | polkit-qt5-1-0.103.0-3.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-06-11 13:11:33 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1061019 | ||
| Bug Blocks: | 928937, 1105546 | ||
|
Description
Lubomir Rintel
2014-02-06 13:49:57 UTC
doesn't look like a cat vomit; builds in mockchain with [1] extra-cmake-modules looks OK [1] https://bugzilla.redhat.com/show_bug.cgi?id=1061019 APPROVED New Package SCM Request ======================= Package Name: polkit-q5-1 Short Description: Qt5 bindings for PolicyKit Owners: lkundrak cicku Branches: f19 f20 el6 epel7 Git done (by process-git-requests). Missing build dependency: extra-cmake-modules is needed by polkit-qt5-1-0.103.0-1.fc20.x86_64 Maybe too late now, but this package appears to build from the same sources as the existing polkit-qt package. Probably would've been better to build qt5 support from there instead of introducing a separate package. Was there some reason that made doing this separately necessary? Lubomir, has this package been imported to F20 already? It's in distgit, but I can't see the package in repos. What I find rather unfortunate is the choosing of name, since qt4 version is called polkit-qt, not polkit-qt-1, so I'd expect this package to be called polkit-qt5 (without the -1 suffix). I think having at least Provides: polkit-qt5 would be nice. No. Well, that only answered the first question; I'll need some time to refresh my memory to answer the second one. Well, the name follows upstream naming. I don't really have any strong opinions about it though. I really expected the package to be retired after no more than a couple of releases, as the qt5 support folds back into the original one. That said; nothing should depend on the current name. Everything should depend on AutoProv'd pkgconfig() or .so provides. Let's close the review, there's little point leaving this open. I'll add a -devel provides for convenience. polkit-qt5-1-0.103.0-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/polkit-qt5-1-0.103.0-3.fc20 polkit-qt5-1-0.103.0-3.fc20 has been pushed to the Fedora 20 stable repository. |