Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1074411
Summary: | Review Request: nodejs-extend - A port of jQuery.extend for Node.js | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jamie Nguyen <jamielinux> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | package-review, tchollingsworth |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2021-07-15 05:26:25 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 956806 |
Description
Jamie Nguyen
2014-03-10 07:15:35 UTC
As you would expect for a "port" there is an obvious bundling issue here - the code is largely copied from jQuery... Argh. For some reason that didn't register. Think I'll just patch out the use of that jquery function in superagent. I'd say this is okay. Requiring the nodejs "jquery" module for something like this is way overkill; you don't need a DOM implementation ("npm install jquery" drags in jsdom) to extend the contents of an array with another one. But you already seemed to have patched it away so I guess it's not worth bothering over now. Let me know if you want to revisit this, I think FPC would be okay with a general exception to expose small bits of jQuery like this. Thanks for the input T.C.! When I find the energy I'll open an FPC ticket. It's quite a popular module (as of right now, 247 other modules list it as a dependency) so it would probably be worth getting into Fedora. This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted. This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience. |