Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1074411 - Review Request: nodejs-extend - A port of jQuery.extend for Node.js
Summary: Review Request: nodejs-extend - A port of jQuery.extend for Node.js
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: nodejs-reviews
TreeView+ depends on / blocked
 
Reported: 2014-03-10 07:15 UTC by Jamie Nguyen
Modified: 2021-07-15 05:30 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-07-15 05:26:25 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Jamie Nguyen 2014-03-10 07:15:35 UTC 
Spec URL: http://jamielinux.fedorapeople.org/supertest/nodejs-extend.spec
SRPM URL: http://jamielinux.fedorapeople.org/supertest/SRPMS/nodejs-extend-1.2.1-1.fc21.src.rpm
Fedora Account System Username: jamielinux

Description:
This is a Node.js port of the classic extend() method from jQuery. It behaves
as you would expect.
Comment 1 Tom Hughes 2014-03-10 18:57:06 UTC 
As you would expect for a "port" there is an obvious bundling issue here - the code is largely copied from jQuery...
Comment 2 Jamie Nguyen 2014-03-10 20:17:48 UTC 
Argh. For some reason that didn't register.

Think I'll just patch out the use of that jquery function in superagent.
Comment 3 T.C. Hollingsworth 2014-03-10 23:18:24 UTC 
I'd say this is okay.  Requiring the nodejs "jquery" module for something like this is way overkill; you don't need a DOM implementation ("npm install jquery" drags in jsdom) to extend the contents of an array with another one.

But you already seemed to have patched it away so I guess it's not worth bothering over now.  Let me know if you want to revisit this, I think FPC would be okay with a general exception to expose small bits of jQuery like this.
Comment 4 Jamie Nguyen 2014-03-11 23:02:57 UTC 
Thanks for the input T.C.!

When I find the energy I'll open an FPC ticket. It's quite a popular module (as of right now, 247 other modules list it as a dependency) so it would probably be worth getting into Fedora.
Comment 5 Package Review 2020-07-10 00:49:21 UTC 
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.
Comment 6 Package Review 2021-07-11 00:45:19 UTC 
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.
Note You need to log in before you can comment on or make changes to this bug.