Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1106720
| Summary: | grass: FTBFS in rawhide | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dennis Gilmore <dennis> | ||||||||
| Component: | grass | Assignee: | Ralf Corsepius <rc040203> | ||||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | rawhide | CC: | cristian.balint, devrim, neteler, pertusus, rc040203, volker27 | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2014-08-10 06:24:38 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | 1037102 | ||||||||||
| Bug Blocks: | 1105908 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Dennis Gilmore
2014-06-09 17:17:41 UTC
Created attachment 905119 [details]
build.log
Created attachment 905120 [details]
root.log
Created attachment 905121 [details]
state.log
This is bug 1037102 (-Werror=format-security). Taking. I have a patch addressing the -Werror=format-security issues pending. However, as this patch is fairly large and intrusive, in a first step, I am going to rebuild this package with -Werror=format-security turned into -Wformat-security. Is that for 6.4.4? It seemed to me like there's something really weird going on during the 6.4.4 build, where it wouldn't find its own headers during the build. (In reply to Volker Fröhlich from comment #6) > Is that for 6.4.4? Yes, my patch is against 6.4.4. > It seemed to me like there's something really weird going > on during the 6.4.4 build, where it wouldn't find its own headers during the > build. Hmm?!? Care to share more details? I've built 6.4.4 many times when working on the patch, but haven't noticed anything resembling to what you are referring to. Since your patch just fixed the issue, I'm inclined to not look into whatever strange thing must have been going on there. Thanks a lot for helping me out. I'll merge that into F21. Anything to be fixed upstream? I sense a couple of misunderstandings and think, I should elaborate what I am trying to do. In an initial step, I was trying to make grass-6.4.4 buildable again. To achieve this, I cleaned up grass.spec a bit, rebased the grass-6.4.3 patches and removed -Werror=format-security from the CFLAGS being while building. I.e. I was not addressing the origin of the code-issues grass has, but simply switching off the trigger which causes the FTBFS. This is the state we now have in grass-6.4.4-2. I.e. a package, which deliberately ignores -Werror=format-security in favor of keeping the package alive in Fedora. In a next step (6.4.4-3), I am going to apply before-mentioned fairly huge patch to grass-6.4.4, which is supposed to address the code-issues in grass-6.4.4, and to re-enable -Werror=format-security. Theoretically, this patch should not have any functional impact. However, due to the size of the patch, I am not expecting it to be bug-free and would rather not apply it to f21 at this point in time, but to keep it rawhide-only until more confidence has been gained. @markusN: This patch definitely should go upstream. However, the patch is such kind of huge, I'd am not expecting upstream to adopt it any time soon. Closing. FTBFS worked around by disabling -Werror=format-security and using -Wformat-security in f21 and rawhide. Thanks for your work, Ralf. (In reply to Ralf Corsepius from comment #10) ... > @markusN: This patch definitely should go upstream. However, the patch is > such kind of huge, I'd am not expecting upstream to adopt it any time soon. However, please note the last year's discussion about earlier attempts of patching GRASS GIS in this way: http://lists.osgeo.org/pipermail/grass-dev/2012-August/059157.html I brought it up on grass-dev again in order to find an upstream solution. |