Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1111433 (synthclone)
Summary: | Review Request: synthclone - A tool to create sample-based instruments | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Brian Monroe <briancmonroe> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | briancmonroe, i, kevin, me, package-review, rdieter |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-08-10 00:49:00 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 177841, 201449, 928937, 1260313 |
Description
Brian Monroe
2014-06-20 03:25:34 UTC
Just a quick note... looks like I had the spec and SRPM links backwards. Sorry about that. I wanted to cover why I'm using ./configure instead of %configure in the spec file is because it's using qmake and not autoconf. I know it throws an warning during the build. Hey Brian, it's been a while - could you rebuild the SRPM for current rawhide, please? Uploading to your fedorahosted space[0] or similar would be better; tools like `fedora-review` can grab the files directly that way. [0] https://fedoraproject.org/wiki/Infrastructure/fedorapeople.org Let's try to find macros and such too, the ./configure doesn't seem ideal at first glance. /usr/lib/rpm/macros.d/macros.qt4 might have some useful things, although looking at existing packages built using qmake is a good idea, I'm not sure of the best practices yet. Use one line for each Requires: . It seems excessive, but it's easier to maintain the package or view diffs of changes to the spec file that way. You can add requires, comment them out, etc a bit more quickly. You may want to skip the ./configure wrapper entirely and use our %{qmake_qt4} macro to invoke qmake directly. (You can also pass qmake arguments that way, using the qmake FOO=bar syntax, rather than the configure-style --foo=bar.) Thanks Kevin, Things have been a little nuts with traveling the last 3 weekends, but I'm hopeful to get to this tonight. Finally got around to fixing this and I think we're good to go. Not using the .config wrapper and using the %{qmake_qt4} macro instead. Tested spec file and srpm against rpmlint. Currently, it's only throwing one warning about a misspelling, that is actually music/midi nomenclature (aftertouch). I reworked the spec file, and it's hosted in a better place: https://paradoxguitarist.fedorapeople.org/synthclone.spec SRPM is available here: https://paradoxguitarist.fedorapeople.org/synthclone-0.3.0-3.fc22.src.rpm Lastly, there's recent koji builds - rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=10934762 f22: http://koji.fedoraproject.org/koji/taskinfo?taskID=10935120 This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience. This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. |