Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1158632 (lxqt-common)
Summary: | Review Request: lxqt-common - Common resources for LXQt desktop suite | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Helio Chissini de Castro <hcastro> |
Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | jmunilla, kevin, mtasaka, package-review, rdieter, ti.eugene |
Target Milestone: | --- | Flags: | rdieter:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-11-20 13:15:53 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1157402 | ||
Bug Blocks: | 928937, 1158999 |
Description
Helio Chissini de Castro
2014-10-29 18:26:00 UTC
My proposition is to include lxqt-common into lxqt srpm: https://copr.fedoraproject.org/coprs/tieugene/LXQT/builds/ Eugeni, sorry, but this is not possible. We can't put everything inside a single package. We even don't have the policy to create a meta package, with explicit requires. What should be done and i will do today, is uploading the other packages, each by each, and with proper build requires and requires. Libraries are automatically solved by deps during package construction and application will requires lxqt-common. After that, we will need edit comps to add LXQt group, and obsoletes the LXDE group. This is the proper process. []'s Technically, it's possible to throw everything into one package (see Source1, Source2 etc., which can be added to the normal Source=Source0), but the general rule of thumb is, if upstream releases things separately, we package them separately. (In reply to Kevin Kofler from comment #3) > Technically, it's possible to throw everything into one package (see > Source1, Source2 etc., which can be added to the normal Source=Source0), but > the general rule of thumb is, if upstream releases things separately, we > package them separately. As I know - whole of LXQT released and will be released together: http://lxqt.org/downloads/lxqt/0.8.0/ I'd like to package whole LXQT with one srpm (as razorqt), but now it is technically impossible. So I deside to make: 1. liblxqt 2. liblxqt-mount and lxqt-globalkeys 3. lxqt (other lxqt things) now that liblxqt is done, I'll start in on this (and others today) Using, https://heliocastro.fedorapeople.org/lxqt/lxqt-common-0.8.0-3.fc21.src.rpm previous -2 link missing naming: ok license: ok sources: ok b48d6df01f23d56115448076ae875680 lxqt-common-0.8.0.tar.xz macros: ok scriptlets: ok 1. SHOULD omit: %{_datadir}/apps/kdm/sessions/lxqt.desktop that's the wrong path, and kdm only uses /usr/share/xsessions anyway. 2. SHOULD package fedora.theme separately (agreed to fix this post-review on irc) another relatively simple package APPROVED. Rex, please do review more carefully. What owns - %{_datadir}/lxqt-qt5/ - %{_sysconfdir}/xdg/pcmanfm-qt - %{_sysconfdir}/xdg/pcmanfm-qt/lxqt ? * And how you checked if the license tag "LGPLv2" is okay? As far as I checked all 666 files, there is no such license information. * %{_datadir}/lxqt-qt5/ => liblxqt (fixed now) * %{_sysconfdir}/xdg/pcmanfm-qt (and subdir) => should be owned here, good spot * licensing: All lxqt (library/resource) packages are LGPLv2+, that is upstream intention. Would be nice to ping them to include a license file here though, so there was no ambiguity. Issues fixed in: https://heliocastro.fedorapeople.org/lxqt/lxqt-common-0.8.0-4.fc21.src.rpm https://heliocastro.fedorapeople.org/lxqt/lxqt-common.spec Looks good, thanks. This last iteration misses owning: %{_sysconfdir}/xdg/lxqt/ But we can review/fix that easily enough post-review. Please move forward with SCM request. Updated with ownership and desktop-file-edit for validation https://heliocastro.fedorapeople.org/lxqt/lxqt-common-0.8.0-5.fc21.src.rpm https://heliocastro.fedorapeople.org/lxqt/lxqt-common.spec New Package SCM Request ======================= Package Name: lxqt-common Short Description: Common resources for LXQt desktop suite Upstream URL: http://lxqt.org/downloads/lxqt/0.8.0/lxqt-common-0.8.0.tar.xz Owners: heliocastro rdieter tieugene Branches: f20 f21 el6 epel7 InitialCC: heliocastro New Package SCM Request ======================= Package Name: lxqt-common Short Description: Common resources for LXQt desktop suite Upstream URL: http://lxqt.org/ Owners: heliocastro rdieter tieugene Branches: f20 f21 el6 epel7 InitialCC: Git done (by process-git-requests). imported |