Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1177038 (qt5-qtwebsockets)
Summary: | Review Request: qt5-qtwebsockets - Qt5 - WebSockets component | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Taylor Braun-Jones <taylor> |
Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | kevin, package-review, rdieter, taylor |
Target Milestone: | --- | Flags: | rdieter:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | qt5-qtwebsockets-5.4.1-1.fc21 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-04-12 02:44:37 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 928937 |
Description
Taylor Braun-Jones
2014-12-23 22:06:51 UTC
Initial comments: 1. License tag NOT ok. License: LGPLv21, LGPLv3, or GPLv2 is invalid. I'd suggest the following which matches what is currently used in other qt5 packages: # See LICENSE.GPL LICENSE.LGPL LGPL_EXCEPTION.txt, for details # See also http://qt-project.org/doc/qt-5.0/qtdoc/licensing.html License: LGPLv2 with exceptions or GPLv3 with exceptions 2. Please document (preferably in a .spec comment) why static libs are needed, BuildRequires: qt5-qtbase-static >= %{version} The "# define to build docs, need to undef this for bootstrapping" comment above the "docs" boolean is incorrect and redundant for this package. This package is not required to build the qtdoc toolchain, and thus there is no need to bootstrap without docs. The only reason one would want to disable docs here at all is to save build time. scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8508255 sources: ok 0c406bca48296d0d99cc93b00f40aca7 qtwebsockets-opensource-src-5.4.0.tar.xz naming: ok macros: ok scriptlets: ok The rest looks fairly clean and simple. Please fix items 1,2 from comment #1, and it looks like we have a winner. (1) There are several inconsistencies in the licensing information that ships with the qtwebsockets package so I've filed a bug to get it sorted out: https://bugreports.qt-project.org/browse/QTBUG-43611 I'll follow up with an updated spec once that bug gets sorted out. I'll also use the new URL for the 'see also' reference: http://doc.qt.io/qt-5/licensing.html (2) qt5-qtbase-static is not actually a build dependencies so it has been removed. The missing file is in qt5-qtbase (probably a side effect of monolithic vs. separate module tarballs). I wouldn't consider it a review blocker, the licensing intent here is fairly consistent and clear. Okay, here are new spec and SRPM files: http://taylor.braun-jones.org/files/2015/01/qt5-qtwebsockets.spec http://taylor.braun-jones.org/files/2015/01/qt5-qtwebsockets-5.4.0-1.el7_.centos.src_.rpm Thanks, APPROVED. sponsored, please let me know if you need anything else. Thanks, Rex. Do you mind if I list you as a secondary owner for this package? Please do, thanks! New Package SCM Request ======================= Package Name: qt5-qtwebsockets Short Description: Qt5 - WebSockets component Upstream URL: http://qt.io Owners: nocnokneo rdieter Branches: f20 f21 f22 el6 epel7 InitialCC: Git done (by process-git-requests). qt5-qtwebsockets-5.4.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/qt5-qtwebsockets-5.4.0-1.el6 qt5-qtwebsockets-5.4.0-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/qt5-qtwebsockets-5.4.0-1.el7 Package qt5-qtwebsockets-5.4.0-1.el7: * should fix your issue, * was pushed to the Fedora EPEL 7 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing qt5-qtwebsockets-5.4.0-1.el7' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2015-1406/qt5-qtwebsockets-5.4.0-1.el7 then log in and leave karma (feedback). qt5-qtwebsockets-5.4.1-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/qt5-qtwebsockets-5.4.1-1.fc22 qt5-qtwebsockets-5.4.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/qt5-qtwebsockets-5.4.1-1.fc21 qt5-qtwebsockets-5.4.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/qt5-qtwebsockets-5.4.1-1.fc20 qt5-qtwebsockets-5.4.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. qt5-qtwebsockets-5.4.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. qt5-qtwebsockets-5.4.1-1.fc22 has been pushed to the Fedora 22 stable repository. qt5-qtwebsockets-5.4.1-1.fc21 has been pushed to the Fedora 21 stable repository. qt5-qtwebsockets-5.4.1-1.fc20 has been pushed to the Fedora 20 stable repository. |