Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1218487
| Summary: | [abrt] hgsvn: common.py:461:get_hgsvn_lock:TypeError: __init__() takes at least 3 arguments (3 given) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dave Johansen <davejohansen> | ||||||
| Component: | hgsvn | Assignee: | Terje Røsten <terjeros> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 21 | CC: | terjeros | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | i686 | ||||||||
| OS: | Unspecified | ||||||||
| URL: | https://retrace.fedoraproject.org/faf/reports/bthash/05ed2fc0d3c67ba967793de342324562267933e7 | ||||||||
| Whiteboard: | abrt_hash:881416b840e365fd6451f507b7a1aa37587ca675 | ||||||||
| Fixed In Version: | hgsvn-0.3.11-2.fc21 hgsvn-0.3.11-2.fc22 hgsvn-0.3.11-2.fc23 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2015-10-23 16:20:37 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Created attachment 1022041 [details]
File: backtrace
Created attachment 1022042 [details]
File: environ
Thanks for report, verified. I saw your patch for this issue against 0.1.9, can you port that fix to 0.3.9? 0.3.9 will be in Fedora soon and I can include your patch. I rebased the patch so it applies against 0.3.8 ( https://bitbucket.org/alexrayne/hgsvn/issues/107/hgsvn-fails-when-file-deleted-in-moved#comment-21766459 ). I'm sure you already know this, but when I build 0.3.8, it still has test failures. hgsvn-0.3.11-1.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-dbe116d632 hgsvn-0.3.11-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-d786995338 hgsvn-0.3.11-1.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update hgsvn' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-dbe116d632 hgsvn-0.3.11-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update hgsvn' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-dc65c41148 hgsvn-0.3.11-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update hgsvn' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-d786995338 Running the commands from the original comment on F22, still errors out:
[dlj@JohansenDev test.hg]$ hgpullsvn --version
hgpullsvn 0.3.11
[dlj@JohansenDev test.hg]$ hgpullsvn
Exception AttributeError: "'lock' object has no attribute 'held'" in <bound method lock.__del__ of <mercurial.lock.lock object at 0xb6623eac>> ignored
Traceback (most recent call last):
File "/usr/bin/hgpullsvn", line 9, in <module>
load_entry_point('hgsvn==0.3.11', 'console_scripts', 'hgpullsvn')()
File "/usr/lib/python2.7/site-packages/hgsvn/run/hgpullsvn.py", line 721, in main
return locked_main(real_main, options, args)
File "/usr/lib/python2.7/site-packages/hgsvn/run/common.py", line 141, in locked_main
l = get_hgsvn_lock()
File "/usr/lib/python2.7/site-packages/hgsvn/common.py", line 429, in get_hgsvn_lock
timeout=0)
TypeError: __init__() takes at least 3 arguments (3 given)
Yeah, seems like mercurial has changed __init__() in lock class in mercurial.lock to include a vfs as first argument. hgsvn code don't handle this at the moment. hgsvn-0.3.11-2.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-dbe116d632 hgsvn-0.3.11-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-dc65c41148 hgsvn-0.3.11-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-d786995338 Is the -2 build working better? hgsvn-0.3.11-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update hgsvn' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-dc65c41148 hgsvn-0.3.11-2.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update hgsvn' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-dbe116d632 hgsvn-0.3.11-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update hgsvn' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-d786995338 hgsvn-0.3.11-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. hgsvn-0.3.11-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. hgsvn-0.3.11-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: I ran the following commands to test if an old error existed in the current version of hgsvn: svnadmin create test svn co file://$PWD/test test.co cd test.co mkdir a touch a/b.txt touch a/c.txt svn add a svn ci -m "Initial revision" svn rm a/b.txt svn mv a d svn ci -m "Moving directory with deleted file" cd .. hgimportsvn file://$PWD/test test.hg cd test.hg hgpullsvn Version-Release number of selected component: hgsvn-0.2.3-3.fc21 Additional info: reporter: libreport-2.3.0 cmdline: /usr/bin/python2 /usr/bin/hgpullsvn executable: /usr/bin/hgpullsvn kernel: 3.19.4-200.fc21.i686 runlevel: N 5 type: Python uid: 1000 Truncated backtrace: common.py:461:get_hgsvn_lock:TypeError: __init__() takes at least 3 arguments (3 given) Traceback (most recent call last): File "/usr/bin/hgpullsvn", line 9, in <module> load_entry_point('hgsvn==0.2.3', 'console_scripts', 'hgpullsvn')() File "/usr/lib/python2.7/site-packages/hgsvn/run/hgpullsvn.py", line 623, in main return locked_main(real_main, options, args) File "/usr/lib/python2.7/site-packages/hgsvn/run/common.py", line 140, in locked_main l = get_hgsvn_lock() File "/usr/lib/python2.7/site-packages/hgsvn/common.py", line 461, in get_hgsvn_lock timeout=0) TypeError: __init__() takes at least 3 arguments (3 given) Local variables in innermost frame: basedir: '.'