1218487 – [abrt] hgsvn: common.py:461:get_hgsvn_lock:TypeError: __init__() takes at least 3 arguments (3 given)

Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1218487 - [abrt] hgsvn: common.py:461:get_hgsvn_lock:TypeError: __init__() takes at least 3 arguments (3 given)

Summary: [abrt] hgsvn: common.py:461:get_hgsvn_lock:TypeError: __init__() takes at lea...

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Fedora
Classification:	Fedora
Component:	hgsvn
Sub Component:
Version:	21
Hardware:	i686
OS:	Unspecified
Priority:	unspecified
Severity:	unspecified
Target Milestone:	---
Assignee:	Terje Røsten
QA Contact:	Fedora Extras Quality Assurance
Docs Contact:
URL:	https://retrace.fedoraproject.org/faf...
Whiteboard:	abrt_hash:881416b840e365fd6451f507b7a...
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2015-05-05 05:08 UTC by Dave Johansen
Modified:	2015-11-01 02:42 UTC (History)
CC List:	1 user (show)
Fixed In Version:	hgsvn-0.3.11-2.fc21 hgsvn-0.3.11-2.fc22 hgsvn-0.3.11-2.fc23
Doc Type:	Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:	2015-10-23 16:20:37 UTC
Type:	---
Embargoed:
Dependent Products:

Attachments	(Terms of Use)
File: backtrace (701 bytes, text/plain) 2015-05-05 05:08 UTC, Dave Johansen	no flags	Details
File: environ (2.92 KB, text/plain) 2015-05-05 05:08 UTC, Dave Johansen	no flags	Details
View All

Description Dave Johansen 2015-05-05 05:08:56 UTC

Description of problem:
I ran the following commands to test if an old error existed in the current version of hgsvn:
svnadmin create test
svn co file://$PWD/test test.co
cd test.co
mkdir a
touch a/b.txt
touch a/c.txt
svn add a
svn ci -m "Initial revision"
svn rm a/b.txt
svn mv a d
svn ci  -m "Moving directory with deleted file"
cd ..
hgimportsvn file://$PWD/test test.hg
cd test.hg
hgpullsvn

Version-Release number of selected component:
hgsvn-0.2.3-3.fc21

Additional info:
reporter:       libreport-2.3.0
cmdline:        /usr/bin/python2 /usr/bin/hgpullsvn
executable:     /usr/bin/hgpullsvn
kernel:         3.19.4-200.fc21.i686
runlevel:       N 5
type:           Python
uid:            1000

Truncated backtrace:
common.py:461:get_hgsvn_lock:TypeError: __init__() takes at least 3 arguments (3 given)

Traceback (most recent call last):
  File "/usr/bin/hgpullsvn", line 9, in <module>
    load_entry_point('hgsvn==0.2.3', 'console_scripts', 'hgpullsvn')()
  File "/usr/lib/python2.7/site-packages/hgsvn/run/hgpullsvn.py", line 623, in main
    return locked_main(real_main, options, args)
  File "/usr/lib/python2.7/site-packages/hgsvn/run/common.py", line 140, in locked_main
    l = get_hgsvn_lock()
  File "/usr/lib/python2.7/site-packages/hgsvn/common.py", line 461, in get_hgsvn_lock
    timeout=0)
TypeError: __init__() takes at least 3 arguments (3 given)

Local variables in innermost frame:
basedir: '.'

Comment 1 Dave Johansen 2015-05-05 05:08:58 UTC

Created attachment 1022041 [details]
File: backtrace

Comment 2 Dave Johansen 2015-05-05 05:08:58 UTC

Created attachment 1022042 [details]
File: environ

Comment 3 Terje Røsten 2015-06-12 07:43:57 UTC

Thanks for report, verified.

Comment 4 Terje Røsten 2015-06-24 16:45:09 UTC

I saw your patch for this issue against 0.1.9, can you port that fix to 0.3.9?

0.3.9 will be in Fedora soon and I can include your patch.

Comment 5 Dave Johansen 2015-09-15 02:46:15 UTC

I rebased the patch so it applies against 0.3.8 ( https://bitbucket.org/alexrayne/hgsvn/issues/107/hgsvn-fails-when-file-deleted-in-moved#comment-21766459 ). I'm sure you already know this, but when I build 0.3.8, it still has test failures.

Comment 6 Fedora Update System 2015-10-10 20:17:06 UTC

hgsvn-0.3.11-1.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-dbe116d632

Comment 7 Fedora Update System 2015-10-10 20:17:14 UTC

hgsvn-0.3.11-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-d786995338

Comment 8 Fedora Update System 2015-10-11 17:51:11 UTC

hgsvn-0.3.11-1.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update hgsvn'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-dbe116d632

Comment 9 Fedora Update System 2015-10-11 18:49:36 UTC

hgsvn-0.3.11-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update hgsvn'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-dc65c41148

Comment 10 Fedora Update System 2015-10-12 03:57:17 UTC

hgsvn-0.3.11-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update hgsvn'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-d786995338

Comment 11 Dave Johansen 2015-10-13 03:22:27 UTC

Running the commands from the original comment on F22, still errors out:
[dlj@JohansenDev test.hg]$ hgpullsvn --version
hgpullsvn 0.3.11
[dlj@JohansenDev test.hg]$ hgpullsvn
Exception AttributeError: "'lock' object has no attribute 'held'" in <bound method lock.__del__ of <mercurial.lock.lock object at 0xb6623eac>> ignored
Traceback (most recent call last):
  File "/usr/bin/hgpullsvn", line 9, in <module>
    load_entry_point('hgsvn==0.3.11', 'console_scripts', 'hgpullsvn')()
  File "/usr/lib/python2.7/site-packages/hgsvn/run/hgpullsvn.py", line 721, in main
    return locked_main(real_main, options, args)
  File "/usr/lib/python2.7/site-packages/hgsvn/run/common.py", line 141, in locked_main
    l = get_hgsvn_lock()
  File "/usr/lib/python2.7/site-packages/hgsvn/common.py", line 429, in get_hgsvn_lock
    timeout=0)
TypeError: __init__() takes at least 3 arguments (3 given)

Comment 12 Terje Røsten 2015-10-13 08:15:45 UTC

Yeah, seems like mercurial has changed __init__() in lock class in mercurial.lock  to include a vfs as first argument. 

hgsvn code don't handle this at the moment.

Comment 13 Fedora Update System 2015-10-13 19:43:44 UTC

hgsvn-0.3.11-2.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-dbe116d632

Comment 14 Fedora Update System 2015-10-13 19:45:11 UTC

hgsvn-0.3.11-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-dc65c41148

Comment 15 Fedora Update System 2015-10-13 19:45:38 UTC

hgsvn-0.3.11-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-d786995338

Comment 16 Terje Røsten 2015-10-13 19:47:54 UTC

Is the -2 build working better?

Comment 17 Fedora Update System 2015-10-14 02:13:32 UTC

hgsvn-0.3.11-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update hgsvn'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-dc65c41148

Comment 18 Fedora Update System 2015-10-14 08:54:28 UTC

hgsvn-0.3.11-2.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update hgsvn'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-dbe116d632

Comment 19 Fedora Update System 2015-10-14 09:27:56 UTC

hgsvn-0.3.11-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update hgsvn'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-d786995338

Comment 20 Fedora Update System 2015-10-23 16:20:33 UTC

hgsvn-0.3.11-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.

Comment 21 Fedora Update System 2015-10-23 17:23:52 UTC

hgsvn-0.3.11-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 22 Fedora Update System 2015-11-01 02:42:26 UTC

hgsvn-0.3.11-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.