Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1224648
| Summary: | Review Request: dnf-plugin-spacewalk - DNF plugin for Spacewalk | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michael Mráka <mmraka> |
| Component: | Package Review | Assignee: | Miroslav Suchý <msuchy> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | msuchy, package-review, tomek |
| Target Milestone: | --- | Flags: | msuchy:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-02-08 23:48:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Michael Mráka
2015-05-25 08:59:58 UTC
Buildroot tag and relevant part in %clean is not needed unless you aim to RHEL5 https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag Source0: https://fedorahosted.org/releases/s/p/spacewalk/%{name}-%{version}.tar.gz There is no tar.gz of this name on this URL. >%install >rm -rf $RPM_BUILD_ROOT Only needed for EL5. It can be safely removed for Fedoras and EL6+. It would be nice if you can consistenly use macros - $FOO vs %{foo}. I suggest to replace $RPM_BUILD_ROOT by %{buildroot} It would be nice if you can (as upstream) include LICENSE file (with %license macro). Fixed. Still valid: Source0: https://fedorahosted.org/releases/s/p/spacewalk/%{name}-%{version}.tar.gz There is no tar.gz of this name on this URL. Either upload the tar.gz to this location. Or put there something like: # source is created by: # git clone https://github.com/spacewalkproject/spacewalk.git # cd client/rhel/dnf-plugin-spacewalk/ && tito build --tgz Source0: %{name}-%{version}.tar.gz Updated spec and srpm (dnf-plugin-spacewalk-2.4.12): Spec URL: https://raw.githubusercontent.com/spacewalkproject/spacewalk/master/client/rhel/dnf-plugin-spacewalk/dnf-plugin-spacewalk.spec SRPM URL: http://koji.spacewalkproject.org/kojifiles/packages/dnf-plugin-spacewalk/2.4.12/1.fc21/src/dnf-plugin-spacewalk-2.4.12-1.fc21.src.rpm APPROVED New Package SCM Request ======================= Package Name: dnf-plugin-spacewalk Short Description: DNF plugin for Spacewalk Upstream URL: https://fedorahosted.org/spacewalk/ Owners: mmraka Branches: f21 f22 f23 InitialCC: Git done (by process-git-requests). dnf-plugin-spacewalk-2.4.13-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/dnf-plugin-spacewalk-2.4.13-1.fc21 dnf-plugin-spacewalk-2.4.13-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/dnf-plugin-spacewalk-2.4.13-1.fc22 dnf-plugin-spacewalk-2.4.13-1.fc23 has been submitted as an update for Fedora 23. https://admin.fedoraproject.org/updates/dnf-plugin-spacewalk-2.4.13-1.fc23 Package dnf-plugin-spacewalk-2.4.13-1.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing dnf-plugin-spacewalk-2.4.13-1.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-13608/dnf-plugin-spacewalk-2.4.13-1.fc21 then log in and leave karma (feedback). dnf-plugin-spacewalk-2.4.15-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update dnf-plugin-spacewalk'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-13612 |